Repository navigation
Comparing changes
Open a pull request
base repository: flutter/packages
base: 138342751909
head repository: flutter/packages
compare: 93baed9106f6
- 9 commits
- 87 files changed
- 8 contributors
Commits on Oct 21, 2026
-
[material_ui] Unskip web tests that pass on CanvasKit and Skwasm: app…
…_bar_theme_test, input_decorator_test, paginated_data_table_test, spell_check_suggestions_toolbar_test (#13352) Removes web skips (`skip: kIsWeb` / `skip: isBrowser`) from tests in `packages/material_ui/test` that now pass on Chrome with both CI web renderers, CanvasKit (dart2js) and Skwasm (dart2wasm). Leaving them skipped hides web regressions. - `app_bar_theme_test.dart`: the `AppBarThemeData implements debugFillProperties` test. Doubles now print the same on web as on other platforms. Also removes the comment that explained the old skip. - `input_decorator_test.dart`: 8 tests: the `OutlineInputBorder` paint/path tests (skipped for #55317) and the `textWidthBasis` clip tests (skipped for #44020). - `paginated_data_table_test.dart`: the large text test (skipped for #43433). It no longer times out. - `spell_check_suggestions_toolbar_test.dart`: `more than three suggestions throws an error`. Also removes the `package:flutter/foundation.dart` import, which is unused now. None of the unskipped tests use goldens. Fixes flutter/flutter#43433 Fixes flutter/flutter#44020 Fixes flutter/flutter#55317 Related issues: - flutter/flutter#87364 This PR changes tests only, so it is exempt from version and CHANGELOG updates. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 4a08a54 - Browse repository at this point
Copy the full SHA 4a08a54View commit details -
[google_maps_flutter_web] Issue 64073 implement my location (#12186)
Implement my location button, add blue dot location Fixes flutter/flutter#64073 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 66acaa8 - Browse repository at this point
Copy the full SHA 66acaa8View commit details -
[google_sign_in_ios, video_player] Specify types for pattern variable…
… declarations (#13362) Adds explicit type annotations to pattern-declared local variables where the matched value's type is not syntactically obvious to satisfy `specify_nonobvious_local_variable_types` (blocking https://dart-review.googlesource.com/c/sdk/+/548220). ## Pre-Review Checklist
Configuration menu - View commit details
-
Copy full SHA for 8e058b4 - Browse repository at this point
Copy the full SHA 8e058b4View commit details -
[camera_windows] Fall back to a physical stream for cameras that reje…
…ct preferred-stream selectors (#12748) Fixes [#140014](flutter/flutter#140014) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 18f9c64 - Browse repository at this point
Copy the full SHA 18f9c64View commit details -
[video_player] Convert player classes to Swift (#13197)
Converts `VideoPlayer` and `TextureBasedVideoPlayer` to Swift. Also converts `AVAssetTrackUtils` since it simplifies calling from Swift, and that's a very simple conversion, as well as the `AV*` class wrappers, in order to replace deprecated methods with newer, Swift-friendlier alternatives. As part of the conversion, adopts Swift Pigeon for the instance-level APIs, so that all of the Pigeon generation in Swift-based (and combines the Pigeon definition files now that they can share a single config). Also adopts Pigeon's new `async` support to make handling async code simpler, so does require some test changes for the API surface change. Intentionally left to later PRs, to limit scope: - The remaining utility files in the `video_player_avfoundation_objc` subtarget (although these should be relatively simple) - The code in `video_player_avfoundation_ios` and `video_player_avfoundation_macos` - Switching the manual event channel code in FVPEventBridge to Pigeon's Swift event channel support As part of the conversion, the minimum Flutter version has been changed to 3.47, which allows dropping versions of iOS and macOS that are no longer supported in 3.47, and thus avoiding the need to convert legacy codepaths that only existing for those no-longer-supported versions. Updates CI's iOS version to target for deprecation checks to iOS 15, rather than 14, to allow using things that require iOS 15 without failing that check (which overrides the deployment version, but is intended to *raise* it, not lower it). Also replaces a number of methods that are deprecated in iOS 16, but for which the replacements were added in iOS 15. Part of flutter/flutter#119105 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for 2ef3d18 - Browse repository at this point
Copy the full SHA 2ef3d18View commit details -
[cupertino_ui] Unskip web tests that pass on CanvasKit and Skwasm: da…
…te_picker_test, spell_check_suggestions_toolbar_test (#13367) Removes web skips from two `cupertino_ui` tests that now pass on the web under both CanvasKit (dart2js) and Skwasm (dart2wasm), so web regressions in these tests are no longer hidden: - `date_picker_test.dart`: the `getColumnWidth` unicode spaces calculation test was skipped with `isBrowser` (flutter/flutter#39998); it now passes on web. - `spell_check_suggestions_toolbar_test.dart`: the "more than three suggestions throws an error" test was skipped with `kIsWeb`; the assertion is thrown correctly on web. The now-unused `package:flutter/foundation.dart` import is removed. Verified locally with `flutter test --platform chrome` and `flutter test --platform chrome --wasm` for both files (all tests pass). Neither unskipped test uses golden files. Related: flutter/flutter#39998 This is a test-only change, so no version bump or CHANGELOG entry is needed. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Configuration menu - View commit details
-
Copy full SHA for f9624a5 - Browse repository at this point
Copy the full SHA f9624a5View commit details -
[cupertino_ui] Fix the installing command of the cupertino_ui package (…
…#13141) Should fix flutter/flutter#193843 (comment).
Configuration menu - View commit details
-
Copy full SHA for 1e20706 - Browse repository at this point
Copy the full SHA 1e20706View commit details -
[rfw] Migrate to material_ui (#12811)
Migrates `rfw` to use `package:material_ui` and updates minimum supported SDK version to Flutter 3.44/Dart 3.12. Part of: flutter/flutter#191322 ## Pre-Review Checklist
Configuration menu - View commit details
-
Copy full SHA for 83c3b82 - Browse repository at this point
Copy the full SHA 83c3b82View commit details
Commits on Oct 22, 2026
-
[material_ui] Port flutter/flutter #186777 MaterialColor test (#12858)
This PR ports the Material-specific test from [flutter/flutter#186777](flutter/flutter#186777) to `material_ui`. The `MaterialColor swatch comparison` test verifies equality for separate swatch maps containing the same standard `Color` values. This is a test-only port, so no package version or changelog entry is needed. Part of [flutter/flutter#188444](flutter/flutter#188444). The PR that removes the test in the framework is flutter/flutter#192716
Configuration menu - View commit details
-
Copy full SHA for 93baed9 - Browse repository at this point
Copy the full SHA 93baed9View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 138342751909...93baed9106f6