Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 108dad0d562e
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 23a05b6ad5d5
Choose a head ref
  • 4 commits
  • 18 files changed
  • 3 contributors

Commits on Oct 23, 2026

  1. [material_ui] Migrate M3 BottomAppBar template to use new gen_defaults ( 

    #13385)

Work toward flutter/flutter#187899
Fixes flutter/flutter#188403

This PR migrates the M3 BottomAppBar defaults template to use the new gen_defaults in material_ui.

## Pre-Review Checklist

**Changelog/version exemption:** No-op, pure migration.

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @elliette
    elliette authored Oct 23, 2026
    Configuration menu
    Copy the full SHA
    b7ec2d0 View commit details
    Browse the repository at this point in the history

  2. [material_ui] Migrate M3 Slider template to use new gen_defaults (#13195 

    )

Work toward flutter/flutter#187899
Fixes flutter/flutter#188433

Migrates the M3 Slider template to the new `gen_defaults`. The generated defaults are unchanged. The first commit only moves the files out of `temporarily_excluded/`.

`activeTickMarkColor` and `inactiveTickMarkColor` still use `.withOpacity(1.0)` instead of `colorWithOpacity`, because that helper drops it when opacity is 1.0 and the output would change.

No version bump or changelog since there's no change for users, same as the other template migrations.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @Crdzbird
    Crdzbird authored Oct 23, 2026
    Configuration menu
    Copy the full SHA
    25bc507 View commit details
    Browse the repository at this point in the history

  3. [material_ui] Migrate M3 SegmentedButton template to use new gen_defa… 

    …ults (#13227)

Work toward flutter/flutter#187899
Fixes flutter/flutter#188432

Migrates the M3 SegmentedButton template to the new `gen_defaults`. The generated defaults are unchanged. The first commit only moves the files out of `temporarily_excluded/`.

The opacities in `resolveStateColor` now come from the state layer tokens instead of being hard-coded, the values are the same.

No version bump or changelog since there's no change for users, same as the other template migrations.

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @Crdzbird
    Crdzbird authored Oct 23, 2026
    Configuration menu
    Copy the full SHA
    9919b95 View commit details
    Browse the repository at this point in the history

  4. [video_player] Fix crash regression with async calls on iOS/macOS (#1… 

    …3383)

Because Pigeon closures have references to the bridge object that serves as the API handler, it's not safe for it to have an `unowned` reference to the player instance that it delegates to. This changes it to a weak reference, and uses dummy return values as necessary for cases where the player has already been destroyed by the time the async call reaches the bridge.

Also includes a unit test simulating that situation, which crashes without the fix.

Fixes flutter/flutter#195056

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    @stuartmorgan
    stuartmorgan authored Oct 23, 2026
    Configuration menu
    Copy the full SHA
    23a05b6 View commit details
    Browse the repository at this point in the history
Loading