Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/packages
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 04781623f406
Choose a base ref
...
head repository: flutter/packages
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 63881f9b118b
Choose a head ref
  • 10 commits
  • 63 files changed
  • 9 contributors

Commits on Nov 5, 2026

  1. [image_picker_ios] PR 5/5 Switch Pigeon to Swift and finish the Objec…

    …tive-C to Swift migration. (#13493)
    
    Switches `image_picker_ios` Pigeon output from Objective-C to Swift and removes the remaining Objective-C packaging:
    
    * `pigeons/messages.dart` now generates `messages.g.swift` instead of `messages.g.h` and `messages.g.m`.
    * `ImagePickerPlugin` and the PHPicker save operation use the generated Swift API, including `PigeonError` instead of `FlutterError`.
    * Deletes the `image_picker_ios_objc` Swift Package Manager target, the `image_picker_ios.h` umbrella header, and the custom module map.
    * The CocoaPods pod is Swift-only and no longer sets `s.module_map`.
    
    The iOS example app and UI tests stay Objective-C until the next PR.
    
    Bumps image_picker_ios to **0.8.13+15**.
    
    PR 5/5 of the Obj-C → Swift migration, following #13394. Part of flutter/flutter#119107
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    victogomez-cs authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    46c69b3 View commit details
    Browse the repository at this point in the history
  2. [material_ui] Paint Scaffold persistent bottom sheet background color…

    … behind the keyboard (#13242)
    
    Ports flutter/flutter#186365 to `material_ui` (design: https://flutter.dev/go/ios-26-keyboard-bleed).
    
    With a persistent bottom sheet (`Scaffold.bottomSheet` or `ScaffoldState.showBottomSheet`) and `resizeToAvoidBottomInset: true`, the sheet is lifted above the keyboard and the `Scaffold`'s own `Material` is what sits behind the keyboard. On iOS 26 the keyboard is translucent, so the scaffold color shows through under the sheet instead of the sheet's color.
    
    `_ScaffoldLayout` now extends the persistent sheet's slot by the part of the keyboard inset not already covered by the bottom bars, while still reporting the content-only height so FAB and `SnackBar` geometry are unchanged. `_StandardBottomSheet` pads its content inside the `BottomSheet`'s `Material` by that amount (growing the sheet's constraints to match), so the sheet's surface continues behind the keyboard. `resizeToAvoidBottomInset: false`, `showModalBottomSheet`, and `BottomSheet`'s public API are unchanged.
    
    Fixes the framework-owned part of flutter/flutter#179482.
    
    ## Before
    
    <img width="368" height="405" alt="before" src="https://github.com/user-attachments/assets/d60ec5b8-60e7-4ea5-881e-d1fe80fa2e4f" />
    
    ## After
    
    <img width="368" height="405" alt="after" src="https://github.com/user-attachments/assets/0f8ae510-40bc-497f-b9a8-9545b5a42e43" />
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    victorsanni authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    a355d5d View commit details
    Browse the repository at this point in the history
  3. [material_ui] Fix InputDecorator intrinsic height when isDense or isC… (

    #13522)
    
    `_RenderDecoration.computeMinIntrinsicHeight` computed the minimum container height differently from `_layout`:
    
    | | Condition | Floor |
    |---|---|---|
    | `_layout` | `isDense \|\| isCollapsed \|\| expands` | `inputHeight` |
    | `computeMinIntrinsicHeight` (before) | `isDense \|\| expands` | `0.0` |
    
    This caused two mismatches between the intrinsic height and the laid out height:
    
    1. **`isDense: true` with compact visual density (the default on desktop and web):** the density offset (-8) shrinks the content height below the input height. Layout clamps it back up to `inputHeight`, but the intrinsic path clamped to `0.0`, so the intrinsic height was 8px too short. Inside `IntrinsicHeight`, this produced the `A RenderFlex overflowed by 8.0 pixels` error reported in the issue.
    2. **`isCollapsed: true` without `isDense` (including `InputDecoration.collapsed`):** the intrinsic path still applied the `kMinInteractiveDimension` (48px) floor, while layout used `inputHeight`, so the intrinsic height was too tall.
    
    This PR aligns `computeMinIntrinsicHeight` with `_layout`.
    
    | Density | Decoration | Laid out height | Intrinsic before | Intrinsic after |
    |---|---|---|---|---|
    | compact | `isDense` + `isCollapsed`, zero padding | 24 | 16 | 24 |
    | compact | `isDense`, zero padding | 24 | 16 | 24 |
    | standard / compact | `isCollapsed` | 24 | 48 | 24 |
    | standard / compact | `InputDecoration.collapsed` | 24 | 48 | 24 |
    
    Fixes flutter/flutter#190536
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    mmohankrishna-lab authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    f631bb8 View commit details
    Browse the repository at this point in the history
  4. [material_ui] Hit test the floating label of InputDecorator at its pa…

    …inted position (#13326)
    
    When the label of an `InputDecorator` floats, `_RenderDecoration.paint` draws the label with `_labelTransform` (a translation and a scale of 0.75). `applyPaintTransform` reports the same transform. But `hitTestChildren` hit tests the label with only its layout offset. A comment there says "The label must be handled specially since we've transformed it", but the code does not do this. Thus the label is painted in one location and hit tested in a different location:
    
    - A tap on the visible floating label does not hit the label.
    - A tap below the visible label, inside its unscaled layout box, hits the label.
    
    This is a problem when the label contains an interactive widget, for example a `PopupMenuButton`, as in the issue. A maintainer said in the issue: "we shouldn't have weird issues with the hit testing here. Flutter should be able to do this" ([comment](flutter/flutter#145324 (comment))).
    
    This change hit tests the label with the transform from `applyPaintTransform` when `_labelTransform` is set. The hit test order of the children does not change. Other children keep the offset-based hit test. There is no API change.
    
    The code in `packages/flutter/lib/src/material` of flutter/flutter is frozen (see flutter/flutter#188444), so this change is only for `material_ui`.
    
    Fixes flutter/flutter#145324
    
    ## Test plan
    
    - Added `Floating label hit test matches its painted position` to `test/input_decorator_test.dart`, for `TextDirection.ltr` and `TextDirection.rtl`. The test taps the painted label two times (2 taps expected), then taps 10 px below the painted label, inside its layout box (no new tap expected).
      - Without the fix: both cases fail with `Expected: <2> Actual: <0>`.
      - With the fix: both cases pass.
    
    ## Pre-Review Checklist
    
    The change uses the repository's pending changelog workflow (`packages/material_ui/pending_changelogs/change_2026_10_20_floating_label_hit_test.yaml`, `version: patch`). No public API documentation change is necessary.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    YeungKC authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    5b5c3b9 View commit details
    Browse the repository at this point in the history
  5. [google_sign_in] Allow GoogleSignIn-iOS 10 (#13306)

    Widens the `GoogleSignIn-iOS` requirement from `9.0.0..<10.0.0` to `9.0.0..<11.0.0` in both the Swift package and the podspec (`~> 9.0` to `>= 9.0, < 11.0`), so apps can resolve GoogleSignIn 10, which allows `gtm-session-fetcher` 4.x and 5.x.
    
    GoogleSignIn 10 requires iOS 15 and macOS 12, and SwiftPM rejects a package whose dependency needs a higher platform than the package declares. This raises the plugin minimums to iOS 15 / macOS 12 (matching Flutter 3.47), updates the macOS example deployment targets, and updates the `google_sign_in` README support table, following #13292.
    
    Apps that also use firebase-ios-sdk 13 (no longer published to CocoaPods) need GoogleSignIn-iOS 10.1.0 or later, which includes google/GoogleSignIn-iOS#626 and widens App Check from 11.x to `11.0.0..<13.0.0`. The range here admits 10.1.0.
    
    Fixes flutter/flutter#194435
    
    ## Pre-Review Checklist
    
    Versioning: `google_sign_in` only changes its README (support table) and macOS example, so it's listed under NEXT without a version bump, as in #13292.
    
    Test exemption: manual dependency update with no plugin code changes. The existing native and integration tests run against GoogleSignIn 10 once SwiftPM or CocoaPods resolves it.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    arifozgun authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    920c2ee View commit details
    Browse the repository at this point in the history
  6. [various] Add engineIdentifier to fake plugin registrars (#13574)

    flutter/flutter#195881 added a required engineIdentifier property to FlutterBaseRegistrar (iOS) and FlutterPluginRegistrar (macOS), which breaks compilation of the test-only registrar fakes and blocks the Flutter roll (#13569).
    
    Implement the property in each fake in a way that also compiles against stable, where the property does not exist yet.
    
    Fixes flutter/flutter#196065
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    elliette authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    674067d View commit details
    Browse the repository at this point in the history
  7. [material_ui] Fix Switch throwing when first painted mid-animation (#…

    …13496)
    
    `_SwitchPainter` only initializes its pressed-state fields inside `paint()`. If the painter's first paint happens in an unusual animation state, those fields are read before they are ever written:
    
    | First paint happens… | `Switch` / `Switch.adaptive` on Android, Fuchsia, Linux, Windows | `Switch.adaptive` on iOS, macOS |
    |---|---|---|
    | while the press reaction is reversing | `LateInitializationError` (`_pressedThumbExtension`) | `Null check operator used on a null value` (`_pressedInactiveThumbRadius!`) |
    | during the toggle animation | OK | `Null check operator used on a null value` (`_pressedInactiveThumbRadius!`) |
    
    This can happen, for example, when a `Switch.adaptive` in a `ListView`'s cache extent (laid out but not painted) changes value and is scrolled into view during its toggle animation, or when a switch under `Opacity(0)` is long-pressed and becomes visible in `onChanged`.
    
    This PR defaults `_pressedThumbExtension` to `0` and falls back to the unpressed thumb radii in the Cupertino branch, as the Material branch already does. Initializing `_pressedThumbExtension` alone (as suggested in the issue) is not enough, because the iOS/macOS null check error comes from `_pressedInactiveThumbRadius!`.
    
    Two regression tests cover both triggers on all platforms (`TargetPlatformVariant.all()`). Without the fix, 8 of the 12 variants fail.
    
    Fixes flutter/flutter#179532
    
    %23%23 Pre-Review Checklist
    
    If you need help, consider asking for advice on the %23hackers-new channel on [Discord].
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    muralikrishmt authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    22027c5 View commit details
    Browse the repository at this point in the history
  8. [material_ui] Disable the DropdownButtonFormField decoration when the…

    … field is disabled (#13473)
    
    `DropdownButtonFormField` passes its `decoration` to `InputDecorator` through `DropdownButton`, but nothing set the decoration's `enabled`. `InputDecorator` only uses its disabled colors and borders, and only ignores hovering (`isHovering` checks `decoration.enabled`), when the decoration is disabled. So a field disabled with `enabled: false`, or with a null `onChanged`, kept its enabled border and fill and still changed color on hover. The selected item and the icon already turned grey, because `DropdownButton` styles those from its own enabled state.
    
    The fix sets `enabled` on the decoration in `_DropdownButtonState.build` from the dropdown's own enabled state. `TextField` does the same before it builds its `InputDecorator`, so a disabled dropdown and a disabled text field in the same form now look alike. A decoration passed in with `enabled: false` stays disabled, as before.
    
    ## Tests
    
    One regression test in `dropdown_form_field_test.dart` checks the decoration that `InputDecorator` gets: enabled with an `onChanged`, disabled with `enabled: false`, and disabled with no `enabled` and a null `onChanged`. It fails on `main` and passes with the fix. `dropdown_form_field_test.dart`, `dropdown_test.dart` and `input_decorator_test.dart` all pass (724 tests), as does the `show_date_picker.2` example test, which is the example that uses `DropdownButtonFormField`.
    
    Fixes flutter/flutter#195192
    
    ## Pre-Review Checklist
    
    I used AI tooling while working on this, and reviewed and tested all of it myself.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    theprantadutta authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    aa134bb View commit details
    Browse the repository at this point in the history
  9. [material_ui] Add tabBar/tab roles and expanded state semantics (#13176)

    Exposes `SemanticsRole.tabBar` and `SemanticsRole.tab` on `NavigationRail` destinations (omitting the redundant `"Tab i of n"` `indexLabel` on web where `role="tablist"` natively computes set size, matching `TabBar` and `Tab`) and sets `Semantics(expanded: ...)` on `DrawerButtonIcon`, `EndDrawerButtonIcon`, and `CalendarDatePicker`'s year/day mode toggle button so assistive technologies announce tab selection and expand/collapse states (WCAG 4.1.2).
    
    Fixes flutter/flutter#173052
    Fixes flutter/flutter#194904
    
    ## Pre-Review Checklist
    
    **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    kevmoo authored Nov 5, 2026
    Configuration menu
    Copy the full SHA
    afe281a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2026

  1. [material_ui] Paint Dialog.fullscreen background color behind the key…

    …board (#13244)
    
    Found while investigating flutter/flutter#179482 (design: https://flutter.dev/go/ios-26-keyboard-bleed). Companion to #13242, which does the same for `Scaffold` persistent bottom sheets.
    
    `Dialog` builds `AnimatedPadding(viewInsets)` → `Material`, so when a text field inside a `Dialog.fullscreen` is focused, the "fullscreen" surface shrinks to the area above the keyboard and the `DialogRoute` barrier is what sits behind the keyboard. On iOS 26 the keyboard is translucent, so the dimmed route underneath shows through under the dialog instead of the dialog's color. Since `Dialog.fullscreen` also removes `viewInsets` from `child`, apps can't work around it from inside the dialog.
    
    For `Dialog.fullscreen`, the `AnimatedPadding` and `MediaQuery.removeViewInsets` now sit inside the `Material`, so the surface keeps covering the whole screen while `child` is laid out above the keyboard exactly as before. Regular `Dialog`s are unchanged.
    
    Part of flutter/flutter#179482.
    
    ## Before
    
    <img width="402" alt="before: the dimmed route behind the dialog shows through the keyboard" src="https://raw.githubusercontent.com/victorsanni/packages/assets-fullscreen-dialog-keyboard/fullscreen_dialog_before.png" />
    
    ## After
    
    <img width="402" alt="after: the dialog's surface continues behind the keyboard" src="https://raw.githubusercontent.com/victorsanni/packages/assets-fullscreen-dialog-keyboard/fullscreen_dialog_after.png" />
    
    ## Pre-Review Checklist
    
    [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
    victorsanni authored Nov 6, 2026
    Configuration menu
    Copy the full SHA
    63881f9 View commit details
    Browse the repository at this point in the history
Loading