Re-enable action_sheet_test.dart.

justinmc · justinmc · commit fe965a5664e6 · 2026-06-29T13:12:28.000-07:00
The only use of TestSemantics in cupertino_ui. I refactored it to use
the preferred tester.find.semantics instead.
diff --git a/packages/cupertino_ui/test/action_sheet_test.dart b/packages/cupertino_ui/test/action_sheet_test.dart
@@ -2,9 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-@Skip(
-  'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
-)
 // This file is run as part of a reduced test set in CI on Mac and Windows
 // machines.
 @Tags(<String>['reduced-test-set'])
@@ -19,8 +16,6 @@ import 'package:flutter/services.dart';
 
 import 'package:flutter_test/flutter_test.dart';
 
-import '../widgets/semantics_tester.dart';
-
 void main() {
   testWidgets('Overall appearance is correct for the light theme', (WidgetTester tester) async {
     await tester.pumpWidget(
@@ -1727,8 +1722,6 @@ void main() {
   }, skip: isBrowser); // https://github.com/flutter/flutter/issues/56001
 
   testWidgets('Action sheet semantics', (WidgetTester tester) async {
-    final semantics = SemanticsTester(tester);
-
     await tester.pumpWidget(
       createAppWithButtonThatLaunchesActionSheet(
         CupertinoActionSheet(
@@ -1746,74 +1739,30 @@ void main() {
     await tester.tap(find.text('Go'));
     await tester.pumpAndSettle();
 
+    final Finder sheetFinder = find.bySemanticsLabel('Alert');
+    final SemanticsNode sheet = tester.semantics.find(find.bySemanticsLabel('Alert'));
+    expect(sheet.role, SemanticsRole.dialog);
+    expect(sheet, isSemantics(label: 'Alert', namesRoute: true, scopesRoute: true));
     expect(
-      semantics,
-      hasSemantics(
-        TestSemantics.root(
-          children: <TestSemantics>[
-            TestSemantics(
-              children: <TestSemantics>[
-                TestSemantics(
-                  children: <TestSemantics>[
-                    TestSemantics(
-                      flags: <SemanticsFlag>[SemanticsFlag.scopesRoute, SemanticsFlag.namesRoute],
-                      label: 'Alert',
-                      role: SemanticsRole.dialog,
-                      children: <TestSemantics>[
-                        TestSemantics(
-                          flags: <SemanticsFlag>[SemanticsFlag.hasImplicitScrolling],
-                          children: <TestSemantics>[
-                            TestSemantics(label: 'The title'),
-                            TestSemantics(label: 'The message'),
-                          ],
-                        ),
-                        TestSemantics(
-                          flags: <SemanticsFlag>[SemanticsFlag.hasImplicitScrolling],
-                          children: <TestSemantics>[
-                            TestSemantics(
-                              flags: <SemanticsFlag>[
-                                SemanticsFlag.isButton,
-                                SemanticsFlag.isFocusable,
-                              ],
-                              actions: <SemanticsAction>[
-                                SemanticsAction.tap,
-                                SemanticsAction.focus,
-                              ],
-                              label: 'One',
-                            ),
-                            TestSemantics(
-                              flags: <SemanticsFlag>[
-                                SemanticsFlag.isButton,
-                                SemanticsFlag.isFocusable,
-                              ],
-                              actions: <SemanticsAction>[
-                                SemanticsAction.tap,
-                                SemanticsAction.focus,
-                              ],
-                              label: 'Two',
-                            ),
-                          ],
-                        ),
-                        TestSemantics(
-                          flags: <SemanticsFlag>[SemanticsFlag.isButton, SemanticsFlag.isFocusable],
-                          actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus],
-                          label: 'Cancel',
-                        ),
-                      ],
-                    ),
-                  ],
-                ),
-              ],
-            ),
-          ],
-        ),
-        ignoreId: true,
-        ignoreRect: true,
-        ignoreTransform: true,
-      ),
+      find.descendant(of: sheetFinder, matching: find.bySemanticsLabel('The title')),
+      findsOneWidget,
     );
-
-    semantics.dispose();
+    expect(
+      find.descendant(of: sheetFinder, matching: find.bySemanticsLabel('The message')),
+      findsOneWidget,
+    );
+    final SemanticsNode buttonOne = tester.semantics.find(
+      find.descendant(of: sheetFinder, matching: find.bySemanticsLabel('One')),
+    );
+    expect(buttonOne, isSemantics(isButton: true, isFocusable: true));
+    final SemanticsNode buttonTwo = tester.semantics.find(
+      find.descendant(of: sheetFinder, matching: find.bySemanticsLabel('Two')),
+    );
+    expect(buttonTwo, isSemantics(isButton: true, isFocusable: true));
+    final SemanticsNode buttonCancel = tester.semantics.find(
+      find.descendant(of: sheetFinder, matching: find.bySemanticsLabel('Cancel')),
+    );
+    expect(buttonCancel, isSemantics(isButton: true, isFocusable: true));
   });
 
   testWidgets('Conflicting scrollbars are not applied by ScrollBehavior to CupertinoActionSheet', (
