Repository navigation
Commit e71b3fd
authored
[vector_graphics_compiler] Handle coordinate lists on text and tspan (#13287)
SVG allows `x`, `y`, `dx` and `dy` on `text` and `tspan` to be a list, one value per character. The compiler parsed them as a single number, so a list like `x="0 4.86 10.01"` threw a confusing `FormatException: Invalid double`.
Lists aren't supported, so it now throws an `UnimplementedError` that names the attribute and value. Single values work as before.
Fixes flutter/flutter#165490
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.1 parent b48550d commit e71b3fd
4 files changed
Lines changed: 62 additions & 5 deletions
File tree
- packages/vector_graphics_compiler
- lib/src/svg
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
1 | 6 | | |
2 | 7 | | |
3 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1570 | 1570 | | |
1571 | 1571 | | |
1572 | 1572 | | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
1573 | 1588 | | |
1574 | 1589 | | |
1575 | 1590 | | |
1576 | 1591 | | |
1577 | 1592 | | |
1578 | 1593 | | |
1579 | | - | |
1580 | | - | |
| 1594 | + | |
| 1595 | + | |
1581 | 1596 | | |
1582 | | - | |
1583 | | - | |
| 1597 | + | |
| 1598 | + | |
1584 | 1599 | | |
1585 | 1600 | | |
1586 | 1601 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
414 | 414 | | |
415 | 415 | | |
416 | 416 | | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
417 | 454 | | |
418 | 455 | | |
419 | 456 | | |
| |||
0 commit comments