Repository navigation
Commit e516d3a
authored
[material_ui] Unskip web tests that pass on CanvasKit and Skwasm: color_scheme_test, elevated_button_test, filled_button_test, icon_button_test (#13327)
Removes the `skip: isBrowser` from the text-contrast accessibility guideline tests in `color_scheme_test.dart`, `elevated_button_test.dart`, `filled_button_test.dart`, and `icon_button_test.dart`. These tests were skipped on the web because `meetsGuideline(textContrastGuideline)` used to throw there, but they now pass on Chrome under both CI web renderers (CanvasKit via dart2js and Skwasm via `--wasm`). Keeping them skipped hides web regressions. The rest of the diff is the formatter re-wrapping the `testWidgets` calls now that the `skip:` argument is gone.
Part of flutter/flutter#44115
This is a test-only change, so no version or CHANGELOG update is needed.
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.1 parent 8b1b579 commit e516d3a
4 files changed
Lines changed: 122 additions & 134 deletions
File tree
- packages/material_ui/test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
686 | 686 | | |
687 | 687 | | |
688 | 688 | | |
689 | | - | |
690 | | - | |
691 | | - | |
692 | | - | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
693 | 693 | | |
694 | | - | |
695 | | - | |
696 | | - | |
697 | | - | |
698 | | - | |
699 | | - | |
700 | | - | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
701 | 701 | | |
702 | | - | |
703 | | - | |
704 | | - | |
705 | | - | |
706 | | - | |
707 | | - | |
708 | | - | |
709 | | - | |
710 | | - | |
711 | | - | |
712 | | - | |
713 | | - | |
714 | | - | |
715 | | - | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
716 | 715 | | |
717 | 716 | | |
718 | | - | |
719 | | - | |
720 | | - | |
721 | | - | |
722 | | - | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
723 | 721 | | |
724 | 722 | | |
725 | 723 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
330 | 330 | | |
331 | 331 | | |
332 | 332 | | |
333 | | - | |
334 | | - | |
335 | | - | |
336 | | - | |
| 333 | + | |
| 334 | + | |
337 | 335 | | |
338 | | - | |
339 | | - | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
344 | | - | |
345 | | - | |
346 | | - | |
347 | | - | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
348 | 345 | | |
349 | 346 | | |
350 | 347 | | |
351 | | - | |
| 348 | + | |
| 349 | + | |
352 | 350 | | |
353 | | - | |
354 | | - | |
| 351 | + | |
| 352 | + | |
355 | 353 | | |
356 | | - | |
357 | | - | |
358 | | - | |
359 | | - | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
360 | 358 | | |
361 | | - | |
362 | | - | |
363 | | - | |
364 | | - | |
365 | | - | |
366 | | - | |
367 | | - | |
368 | | - | |
369 | | - | |
370 | | - | |
371 | | - | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
372 | 368 | | |
373 | 369 | | |
374 | 370 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
436 | 436 | | |
437 | 437 | | |
438 | 438 | | |
439 | | - | |
440 | | - | |
441 | | - | |
442 | | - | |
443 | | - | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
444 | 442 | | |
445 | | - | |
446 | | - | |
447 | | - | |
448 | | - | |
449 | | - | |
450 | | - | |
451 | | - | |
452 | | - | |
453 | | - | |
454 | | - | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
455 | 452 | | |
456 | 453 | | |
457 | 454 | | |
458 | | - | |
| 455 | + | |
| 456 | + | |
459 | 457 | | |
460 | | - | |
461 | | - | |
| 458 | + | |
| 459 | + | |
462 | 460 | | |
463 | | - | |
464 | | - | |
465 | | - | |
466 | | - | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
467 | 465 | | |
468 | | - | |
469 | | - | |
470 | | - | |
471 | | - | |
472 | | - | |
473 | | - | |
474 | | - | |
475 | | - | |
476 | | - | |
477 | | - | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
478 | 474 | | |
479 | 475 | | |
480 | 476 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2046 | 2046 | | |
2047 | 2047 | | |
2048 | 2048 | | |
2049 | | - | |
2050 | | - | |
2051 | | - | |
2052 | | - | |
| 2049 | + | |
| 2050 | + | |
| 2051 | + | |
| 2052 | + | |
2053 | 2053 | | |
2054 | | - | |
2055 | | - | |
2056 | | - | |
2057 | | - | |
2058 | | - | |
2059 | | - | |
2060 | | - | |
2061 | | - | |
2062 | | - | |
2063 | | - | |
| 2054 | + | |
| 2055 | + | |
| 2056 | + | |
| 2057 | + | |
| 2058 | + | |
| 2059 | + | |
| 2060 | + | |
| 2061 | + | |
| 2062 | + | |
2064 | 2063 | | |
2065 | 2064 | | |
2066 | 2065 | | |
2067 | | - | |
| 2066 | + | |
| 2067 | + | |
2068 | 2068 | | |
2069 | | - | |
2070 | | - | |
| 2069 | + | |
| 2070 | + | |
2071 | 2071 | | |
2072 | | - | |
2073 | | - | |
2074 | | - | |
2075 | | - | |
| 2072 | + | |
| 2073 | + | |
| 2074 | + | |
| 2075 | + | |
2076 | 2076 | | |
2077 | | - | |
2078 | | - | |
2079 | | - | |
2080 | | - | |
2081 | | - | |
2082 | | - | |
2083 | | - | |
| 2077 | + | |
| 2078 | + | |
| 2079 | + | |
| 2080 | + | |
| 2081 | + | |
| 2082 | + | |
| 2083 | + | |
2084 | 2084 | | |
2085 | | - | |
2086 | | - | |
2087 | | - | |
2088 | | - | |
2089 | | - | |
2090 | | - | |
2091 | | - | |
| 2085 | + | |
| 2086 | + | |
| 2087 | + | |
| 2088 | + | |
| 2089 | + | |
| 2090 | + | |
| 2091 | + | |
2092 | 2092 | | |
2093 | | - | |
| 2093 | + | |
2094 | 2094 | | |
2095 | | - | |
2096 | | - | |
2097 | | - | |
2098 | | - | |
| 2095 | + | |
| 2096 | + | |
2099 | 2097 | | |
2100 | 2098 | | |
2101 | 2099 | | |
| |||
0 commit comments