You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e4ade63
Browse filesBrowse the repository at this point in the historyBrowse files
[google_maps_flutter] Adopt Pigeon's Kotlin 'suspend' support (#12980)
Converts the Pigeon generation from the older callback system to the new Kotlin `suspend` support. While this is not any simpler while the code is Java, it has several benefits:
- It makes future `pigeon` mass updates much simpler, since this is the new default generation mode.
- It simplifies adoption of the JNI-based Pigeon backend, which always uses the `suspend` style.
- It will simplify the tests when converting them to Kotlin.
Part of flutter/flutter#192417
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/CirclesController.java
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/ClusterManagersController.java
+1-4Lines changed: 1 addition & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -23,8 +23,6 @@
23
23
importjava.util.List;
24
24
importjava.util.Map;
25
25
importjava.util.Set;
26
-
importkotlin.Result;
27
-
importkotlin.Unit;
28
26
29
27
/**
30
28
* Controls cluster managers and exposes interfaces for adding and removing cluster items for
@@ -238,8 +236,7 @@ public boolean onClusterClick(Cluster<MarkerBuilder> cluster) {
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapController.java
+35-38Lines changed: 35 additions & 38 deletions
Original file line number
Diff line number
Diff line change
@@ -53,10 +53,8 @@
53
53
importjava.util.List;
54
54
importjava.util.Objects;
55
55
importjava.util.Set;
56
-
importkotlin.Result;
57
56
importkotlin.Unit;
58
-
importkotlin.jvm.functions.Function1;
59
-
importorg.jetbrains.annotations.NotNull;
57
+
importkotlin.coroutines.Continuation;
60
58
61
59
/** Controller of a single GoogleMaps MapView instance. */
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapInitializer.java
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/GroundOverlaysController.java
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/MarkersController.java
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/PolygonsController.java
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/PolylinesController.java
0 commit comments