Skip to content

Commit da4e442

Browse files
[vector_graphics] Remove unnecessary Material imports (#12798)
Removes unnecessary `material` imports from `vector_graphics` to decouple `vector_graphics` from Material/Cupertino since they will eventually be removed from the core SDK. Part of: flutter/flutter#191322 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 105b077 commit da4e442

4 files changed

Lines changed: 10 additions & 6 deletions

File tree

‎packages/vector_graphics/CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## NEXT
22

33
* Updates minimum supported SDK version to Flutter 3.41/Dart 3.11.
4+
* Removes unnecessary Material imports.
45
* Fixes deprecation lints.
56

67
## 1.2.3

‎packages/vector_graphics/test/caching_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import 'dart:async';
66
import 'dart:typed_data';
77

8-
import 'package:flutter/material.dart';
8+
import 'package:flutter/widgets.dart';
99
import 'package:flutter_test/flutter_test.dart';
1010
import 'package:vector_graphics/src/vector_graphics.dart';
1111
import 'package:vector_graphics_codec/vector_graphics_codec.dart';

‎packages/vector_graphics/test/render_vector_graphics_test.dart‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ library;
99
import 'dart:typed_data';
1010
import 'dart:ui' as ui;
1111

12-
import 'package:flutter/material.dart';
1312
import 'package:flutter/rendering.dart';
13+
import 'package:flutter/widgets.dart';
1414
import 'package:flutter_test/flutter_test.dart';
1515
import 'package:vector_graphics/src/listener.dart';
1616
import 'package:vector_graphics/src/render_vector_graphic.dart';
@@ -115,7 +115,10 @@ void main() {
115115

116116
final ui.Image firstImage = context.canvas.lastImage!;
117117

118-
renderVectorGraphic.colorFilter = const ui.ColorFilter.mode(Colors.red, ui.BlendMode.colorBurn);
118+
renderVectorGraphic.colorFilter = const ui.ColorFilter.mode(
119+
ui.Color(0xFFFF0000),
120+
ui.BlendMode.colorBurn,
121+
);
119122
renderVectorGraphic.paint(context, Offset.zero);
120123

121124
expect(firstImage.debugDisposed, false);
@@ -288,7 +291,7 @@ void main() {
288291
test('Color filter applies clip', () async {
289292
final render = RenderPictureVectorGraphic(
290293
pictureInfo,
291-
const ui.ColorFilter.mode(Colors.green, ui.BlendMode.difference),
294+
const ui.ColorFilter.mode(ui.Color(0xFF00FF00), ui.BlendMode.difference),
292295
null,
293296
);
294297
render.layout(BoxConstraints.tight(const Size(50, 50)));

‎packages/vector_graphics/test/vector_graphics_test.dart‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ import 'dart:async';
66
import 'dart:convert' show base64Decode;
77

88
import 'package:flutter/foundation.dart';
9-
import 'package:flutter/material.dart';
109
import 'package:flutter/rendering.dart';
10+
import 'package:flutter/widgets.dart';
1111
import 'package:flutter_test/flutter_test.dart';
1212
import 'package:vector_graphics/src/listener.dart';
1313
import 'package:vector_graphics/src/vector_graphics.dart';
@@ -575,7 +575,7 @@ void main() {
575575
textDirection: TextDirection.ltr,
576576
child: createCompatVectorGraphic(
577577
loader: const AssetBytesLoader('foo.svg'),
578-
colorFilter: const ColorFilter.mode(Colors.red, BlendMode.srcIn),
578+
colorFilter: const ColorFilter.mode(Color(0xFFFF0000), BlendMode.srcIn),
579579
opacity: const AlwaysStoppedAnimation<double>(0.5),
580580
),
581581
),

0 commit comments

Comments
 (0)