Skip to content

Commit d50d1b8

Browse files
authored
[pigeon][video_player] Disable video_player and pigeon flakes blocking latest flutter -> packages roll (#13003)
Work towards flutter/flutter#193291, flutter/flutter#179154, flutter/flutter#193300 Disables the `pigeon` and `video_player` flakes that manifested on the most recent flutter -> packages autoroll (#12999) ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 071775b commit d50d1b8

2 files changed

Lines changed: 31 additions & 22 deletions

File tree

‎packages/pigeon/platform_tests/shared_test_plugin_code/lib/integration_tests.dart‎

Lines changed: 28 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2367,27 +2367,34 @@ void runPigeonIntegrationTests(TargetGenerator targetGenerator) {
23672367
await completer.future;
23682368
}, skip: !eventChannelSupported.contains(targetGenerator));
23692369

2370-
testWidgets('event channels handle multiple instances', (_) async {
2371-
final completer1 = Completer<void>();
2372-
final completer2 = Completer<void>();
2373-
final Stream<int> events1 = streamConsistentNumbers(instanceName: '1');
2374-
final Stream<int> events2 = streamConsistentNumbers(instanceName: '2');
2375-
2376-
events1
2377-
.listen((int event) {
2378-
expect(event, 1);
2379-
})
2380-
.onDone(() => completer1.complete());
2381-
2382-
events2
2383-
.listen((int event) {
2384-
expect(event, 2);
2385-
})
2386-
.onDone(() => completer2.complete());
2387-
2388-
await completer1.future;
2389-
await completer2.future;
2390-
}, skip: !eventChannelSupported.contains(targetGenerator));
2370+
testWidgets(
2371+
'event channels handle multiple instances',
2372+
(_) async {
2373+
final completer1 = Completer<void>();
2374+
final completer2 = Completer<void>();
2375+
final Stream<int> events1 = streamConsistentNumbers(instanceName: '1');
2376+
final Stream<int> events2 = streamConsistentNumbers(instanceName: '2');
2377+
2378+
events1
2379+
.listen((int event) {
2380+
expect(event, 1);
2381+
})
2382+
.onDone(() => completer1.complete());
2383+
2384+
events2
2385+
.listen((int event) {
2386+
expect(event, 2);
2387+
})
2388+
.onDone(() => completer2.complete());
2389+
2390+
await completer1.future;
2391+
await completer2.future;
2392+
},
2393+
skip:
2394+
!eventChannelSupported.contains(targetGenerator) ||
2395+
// Flaky on macOS Swift, see https://github.com/flutter/flutter/issues/179154
2396+
(targetGenerator == TargetGenerator.swift && defaultTargetPlatform == TargetPlatform.macOS),
2397+
);
23912398

23922399
testWidgets('constants are generated correctly', (WidgetTester _) async {
23932400
expect(aStringConstant, 'stringConstantValue');

‎packages/video_player/video_player/example/integration_test/video_player_test.dart‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,9 @@ void main() {
286286
// MEDIA_ELEMENT_ERROR on web, see https://github.com/flutter/flutter/issues/169219
287287
kIsWeb ||
288288
// Hanging on Android, see https://github.com/flutter/flutter/issues/160797
289-
defaultTargetPlatform == TargetPlatform.android,
289+
defaultTargetPlatform == TargetPlatform.android ||
290+
// Hanging on macOS, see https://github.com/flutter/flutter/issues/193300
291+
defaultTargetPlatform == TargetPlatform.macOS,
290292
);
291293
});
292294

0 commit comments

Comments
 (0)