Repository navigation
Commit b762b3f
authored
[cupertino_ui] Include selectionHandleColor in NoDefaultCupertinoThemeData equality (#13450)
`NoDefaultCupertinoThemeData.operator ==` and `hashCode` leave out `selectionHandleColor`, so two themes that differ only in that color compare equal. `CupertinoThemeData`, which extends it, already includes the field. Because `ThemeData ==` compares `cupertinoOverrideTheme`, an app that passes a `NoDefaultCupertinoThemeData` there and changes only its `selectionHandleColor` gets an "equal" `ThemeData`, and dependents aren't rebuilt.
This adds the field to both methods, matching `CupertinoThemeData`, and adds a unit test.
Fixes flutter/flutter#195391
## Pre-Review Checklist1 parent 99943dd commit b762b3f
3 files changed
Lines changed: 13 additions & 0 deletions
File tree
- packages/cupertino_ui
- lib/src
- pending_changelogs
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
593 | 593 | | |
594 | 594 | | |
595 | 595 | | |
| 596 | + | |
596 | 597 | | |
597 | 598 | | |
598 | 599 | | |
| |||
604 | 605 | | |
605 | 606 | | |
606 | 607 | | |
| 608 | + | |
607 | 609 | | |
608 | 610 | | |
609 | 611 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
228 | 228 | | |
229 | 229 | | |
230 | 230 | | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
231 | 239 | | |
232 | 240 | | |
233 | 241 | | |
| |||
0 commit comments