Skip to content

Commit b0abd88

Browse files
authored
[camera_android_camerax] Move misplaced Javadoc above annotations (#13040)
Moved comments above the annotations to fix `dangling-doc-comments` compiler warning. This is part of the work to ensure packages works on JDK 25. JDK 25's compiler added a `dangling-doc-comments` is a javac lint check that was new in JDK 23 ([JDK-8303689](https://bugs.openjdk.org/browse/JDK-8303689)) that warns when a Javadoc comment isnt attached to class, method, or field. Partially Addresses flutter/flutter#193404 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent da4e442 commit b0abd88

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎packages/camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/DeviceOrientationManager.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,14 @@ public void start() {
6060
orientationEventListener.enable();
6161
}
6262

63-
@VisibleForTesting
64-
@NonNull
6563
/**
6664
* Creates an {@link OrientationEventListener} that will call the callback method of the {@link
6765
* DeviceOrientationManagerProxyApi} whenever it is notified of a new device orientation and this
6866
* {@code DeviceOrientationManager} instance determines that the orientation of the device {@link
6967
* Configuration} has changed.
7068
*/
69+
@VisibleForTesting
70+
@NonNull
7171
protected OrientationEventListener createOrientationEventListener() {
7272
return new OrientationEventListener(getContext()) {
7373
@Override

0 commit comments

Comments
 (0)