You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit a3ffe32
Browse filesBrowse the repository at this point in the historyBrowse files
[google_maps_flutter] Adopts new async/await Swift Pigeon support (#12860)
Switches from the callback-based Pigeon API to the new async/await-based API, which is:
- more idiomatic modern Swift
- safer, both since it uses Pigeon-generated actor annotations to ensure proper threading, and because it prevents the error case of calling the callback some number of times other than exactly once (which violates the engine API contract)
- the syntax used by the new FFI backend that we plan to switch to in a follow-up
I verified that with this version of Pigeon we are no longer seeing thread violation logging in manual testing (see flutter/flutter#192199)
There is some extra `Task` boilerplate in many callbacks still because we are implementing APIs that are defined by the Google Maps API, and those are not yet using `async` and actor annotations, so we have to bridge them in the plugin layer.
Part of flutter/flutter#192720
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_ios_sdk10/example/ios/RunnerTests/TestUtils/TestMapEventHandler.swift
+33-92Lines changed: 33 additions & 92 deletions
Original file line number
Diff line number
Diff line change
@@ -8,109 +8,50 @@ import Foundation
8
8
9
9
/// Fake implementation of MapEventDelegate for unit tests.
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_ios_sdk10/example/ios/RunnerTests/TileProviderControllerTests.swift
+4-5Lines changed: 4 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -24,20 +24,19 @@ class TestTileProvider: TileProviderDelegate {
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_ios_sdk10/ios/google_maps_flutter_ios_sdk10/Sources/google_maps_flutter_ios_sdk10/CircleController.swift
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_ios_sdk10/ios/google_maps_flutter_ios_sdk10/Sources/google_maps_flutter_ios_sdk10/ClusterManagersController.swift
+3-1Lines changed: 3 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -73,7 +73,9 @@ class ClusterManagersController {
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_ios_sdk10/ios/google_maps_flutter_ios_sdk10/Sources/google_maps_flutter_ios_sdk10/GoogleMapController.swift
+15-5Lines changed: 15 additions & 5 deletions
Original file line number
Diff line number
Diff line change
@@ -313,17 +313,23 @@ public class GoogleMapController: NSObject, GMSMapViewDelegate, FlutterPlatformV
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_ios_sdk10/ios/google_maps_flutter_ios_sdk10/Sources/google_maps_flutter_ios_sdk10/GroundOverlayController.swift
+3-1Lines changed: 3 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -197,7 +197,9 @@ class GroundOverlaysController {
Copy file name to clipboardExpand all lines: packages/google_maps_flutter/google_maps_flutter_ios_sdk10/ios/google_maps_flutter_ios_sdk10/Sources/google_maps_flutter_ios_sdk10/MarkerController.swift
0 commit comments