Repository navigation
Commit 6968b24
authored
[material_ui] Fix time picker input validation for 24-hour locales (#13033)
In input mode, `showTimePicker` and `TimePickerDialog` parsed the hour as a 12-hour value when the 24-hour format came from the locale (e.g. en_GB), even though the input UI showed 24-hour fields without an AM/PM selector. As a result, hours 0 and 13–23 were rejected, and hours 1–12 could be shifted by 12 hours depending on the AM/PM period of the selected time.
This PR makes the hour parser use the same hour format as the rest of the picker, which already takes the locale into account.
Fixes flutter/flutter#74018
## Pre-Review Checklist
**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.1 parent 382004f commit 6968b24
3 files changed
Lines changed: 67 additions & 1 deletion
File tree
- packages/material_ui
- lib/src
- pending_changelogs
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1781 | 1781 | | |
1782 | 1782 | | |
1783 | 1783 | | |
1784 | | - | |
| 1784 | + | |
1785 | 1785 | | |
1786 | 1786 | | |
1787 | 1787 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2142 | 2142 | | |
2143 | 2143 | | |
2144 | 2144 | | |
| 2145 | + | |
| 2146 | + | |
| 2147 | + | |
| 2148 | + | |
| 2149 | + | |
| 2150 | + | |
| 2151 | + | |
| 2152 | + | |
| 2153 | + | |
| 2154 | + | |
| 2155 | + | |
| 2156 | + | |
| 2157 | + | |
| 2158 | + | |
| 2159 | + | |
| 2160 | + | |
| 2161 | + | |
| 2162 | + | |
| 2163 | + | |
| 2164 | + | |
| 2165 | + | |
| 2166 | + | |
| 2167 | + | |
| 2168 | + | |
| 2169 | + | |
| 2170 | + | |
| 2171 | + | |
| 2172 | + | |
| 2173 | + | |
| 2174 | + | |
| 2175 | + | |
| 2176 | + | |
| 2177 | + | |
| 2178 | + | |
| 2179 | + | |
| 2180 | + | |
| 2181 | + | |
| 2182 | + | |
| 2183 | + | |
| 2184 | + | |
| 2185 | + | |
| 2186 | + | |
| 2187 | + | |
| 2188 | + | |
| 2189 | + | |
| 2190 | + | |
| 2191 | + | |
| 2192 | + | |
| 2193 | + | |
| 2194 | + | |
2145 | 2195 | | |
2146 | 2196 | | |
2147 | 2197 | | |
| |||
2875 | 2925 | | |
2876 | 2926 | | |
2877 | 2927 | | |
| 2928 | + | |
| 2929 | + | |
2878 | 2930 | | |
2879 | 2931 | | |
2880 | 2932 | | |
2881 | 2933 | | |
2882 | 2934 | | |
| 2935 | + | |
| 2936 | + | |
| 2937 | + | |
| 2938 | + | |
| 2939 | + | |
| 2940 | + | |
| 2941 | + | |
| 2942 | + | |
| 2943 | + | |
| 2944 | + | |
| 2945 | + | |
2883 | 2946 | | |
2884 | 2947 | | |
2885 | 2948 | | |
| |||
0 commit comments