Skip to content

Commit 51c71be

Browse files
authored
[material_ui] Temporarily exclude material_ui from non-Wasm web unit tests (#13537)
Temporarily disable `material_ui` web tests due to flutter/flutter#195700 flutter/flutter#193485 made each web test suite noticeably slower to load. That has pushed the master-channel `Linux_web web_dart_unit_test_shard_2 master` shard, which runs `material_ui`, over its 90-minute timeout. The timeouts are blocking the flutter/flutter → flutter/packages roller. This PR temporarily turns off the non-Wasm web unit tests for `material_ui` while we work on a long-term fix. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 1cdc73e commit 51c71be

2 files changed

Lines changed: 15 additions & 1 deletion

File tree

‎.ci/targets/web_dart_unit_tests.yaml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,6 @@ tasks:
88
"dart-test",
99
"--platform=chrome",
1010
"--package-tags=script/configs/web_dart_unit_test_tags.yaml",
11-
"--exclude=script/configs/dart_unit_tests_exceptions.yaml"
11+
"--exclude=script/configs/dart_unit_tests_exceptions.yaml",
12+
"--exclude=script/configs/web_dart_unit_tests_exceptions.yaml"
1213
]
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Packages that are excluded from the (non-Wasm) web dart unit tests.
2+
#
3+
# This list should be kept as short as possible, and things should remain here
4+
# only as long as necessary.
5+
6+
# Temporarily excluded because https://github.com/flutter/flutter/pull/193485
7+
# increased per-suite DDC load times enough to push the master-channel web
8+
# unit test shard containing material_ui over its 90 minute timeout, which is
9+
# blocking the flutter/flutter -> flutter/packages roller. material_ui is still
10+
# tested on the web via the Wasm web unit tests.
11+
# TODO(elliette): Renable once https://github.com/flutter/flutter/issues/195700
12+
# is resolved.
13+
- material_ui

0 commit comments

Comments
 (0)