Skip to content

Commit 3c6ce59

Browse files
[cupertino_icons] Migrate to cupertino_ui (#12649)
Update `cupertino_icons` to use `cupertino_ui` instead of `flutter/cupertino` Part of #flutter/flutter#191322 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 08e1067 commit 3c6ce59

6 files changed

Lines changed: 12 additions & 11 deletions

File tree

‎third_party/packages/cupertino_icons/CHANGELOG.md‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
## NEXT
1+
## 2.0.0
22

3-
* Updates minimum supported SDK version to Flutter 3.41/Dart 3.11.
3+
* Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.
4+
* Migrates to use `cupertino_ui` instead of `flutter/cupertino.dart`.
45

56
## 1.0.9
67

‎third_party/packages/cupertino_icons/example/example.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This package is used via [`CupertinoIcons`](https://api.flutter.dev/flutter/cupe
44

55
<?code-excerpt "cupertino_icons_test.dart (CupertinoIcon)"?>
66
```dart
7-
const icon = Icon(CupertinoIcons.heart_fill, color: Colors.pink, size: 24.0);
7+
const icon = Icon(CupertinoIcons.heart_fill, color: CupertinoColors.systemPink, size: 24.0);
88
```
99

1010
For a list of all icons, see [`CupertinoIcons`](https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html#constants) [class documentation constants](https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html#constants).

‎third_party/packages/cupertino_icons/pubspec.yaml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,14 @@ name: cupertino_icons
33
description: Default icons asset for Cupertino widgets based on Apple styled icons
44
repository: https://github.com/flutter/packages/tree/main/third_party/packages/cupertino_icons
55
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+cupertino_icons%22
6-
version: 1.0.9
6+
version: 2.0.0
77

88
environment:
9-
sdk: ^3.11.0
9+
sdk: ^3.12.0
1010

1111
dev_dependencies:
1212
collection: ^1.18.0
13+
cupertino_ui: ^1.0.0
1314
flutter:
1415
sdk: flutter
1516
flutter_test:

‎third_party/packages/cupertino_icons/test/cupertino_icons_golden_test.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import 'dart:io' show File, Platform;
66

77
import 'package:collection/collection.dart';
8-
import 'package:flutter/cupertino.dart';
8+
import 'package:cupertino_ui/cupertino_ui.dart';
99
import 'package:flutter/foundation.dart';
1010
import 'package:flutter/services.dart';
1111
import 'package:flutter_test/flutter_test.dart';

‎third_party/packages/cupertino_icons/test/cupertino_icons_test.dart‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,16 @@
55
/// This test file is primarily here to serve as a source for code excerpts.
66
library;
77

8-
import 'package:flutter/cupertino.dart';
9-
import 'package:flutter/material.dart';
8+
import 'package:cupertino_ui/cupertino_ui.dart';
109
import 'package:flutter_test/flutter_test.dart';
1110

1211
void main() {
1312
testWidgets('Cupertino Icon Test', (WidgetTester tester) async {
1413
// #docregion CupertinoIcon
15-
const icon = Icon(CupertinoIcons.heart_fill, color: Colors.pink, size: 24.0);
14+
const icon = Icon(CupertinoIcons.heart_fill, color: CupertinoColors.systemPink, size: 24.0);
1615
// #enddocregion CupertinoIcon
1716

18-
await tester.pumpWidget(const MaterialApp(home: Scaffold(body: icon)));
17+
await tester.pumpWidget(const CupertinoApp(home: icon));
1918

2019
expect(find.byType(Icon), findsOne);
2120
});

‎third_party/packages/cupertino_icons/test/icons_list.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
import 'package:flutter/cupertino.dart';
5+
import 'package:cupertino_ui/cupertino_ui.dart';
66

77
int _compare(IconData a, IconData b) => a.codePoint.compareTo(b.codePoint);
88

0 commit comments

Comments
 (0)