Repository navigation
Commit 2826fb1
committed
[two_dimensional_scrollables] Search only regular spans for the visible range
_binarySearchFirstFromMap searched the whole metrics map, but trailing
pinned spans sit at its end and fail the regular-span condition, so the
condition is not monotonic across the map. Whenever the search probed a
trailing pinned span it discarded the regular spans before it: with
columnCount: 3 and trailingPinnedColumnCount: 2, a scroll left no regular
column in the visible range and its cells disappeared.
Restrict the search to the indices of the regular spans, and cover more
than one trailing pinned row and column.1 parent aedd88c commit 2826fb1
3 files changed
Lines changed: 103 additions & 3 deletions
File tree
- packages/two_dimensional_scrollables
- lib/src/table_view
- test/table_view
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1036 | 1036 | | |
1037 | 1037 | | |
1038 | 1038 | | |
1039 | | - | |
| 1039 | + | |
| 1040 | + | |
| 1041 | + | |
| 1042 | + | |
| 1043 | + | |
| 1044 | + | |
| 1045 | + | |
| 1046 | + | |
| 1047 | + | |
| 1048 | + | |
| 1049 | + | |
| 1050 | + | |
1040 | 1051 | | |
1041 | 1052 | | |
1042 | 1053 | | |
1043 | | - | |
1044 | | - | |
| 1054 | + | |
| 1055 | + | |
1045 | 1056 | | |
1046 | 1057 | | |
1047 | 1058 | | |
| |||
1081 | 1092 | | |
1082 | 1093 | | |
1083 | 1094 | | |
| 1095 | + | |
| 1096 | + | |
1084 | 1097 | | |
1085 | 1098 | | |
1086 | 1099 | | |
1087 | 1100 | | |
| 1101 | + | |
| 1102 | + | |
1088 | 1103 | | |
1089 | 1104 | | |
1090 | 1105 | | |
| |||
1112 | 1127 | | |
1113 | 1128 | | |
1114 | 1129 | | |
| 1130 | + | |
| 1131 | + | |
1115 | 1132 | | |
1116 | 1133 | | |
1117 | 1134 | | |
1118 | 1135 | | |
| 1136 | + | |
| 1137 | + | |
1119 | 1138 | | |
1120 | 1139 | | |
1121 | 1140 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4183 | 4183 | | |
4184 | 4184 | | |
4185 | 4185 | | |
| 4186 | + | |
| 4187 | + | |
| 4188 | + | |
| 4189 | + | |
| 4190 | + | |
| 4191 | + | |
| 4192 | + | |
| 4193 | + | |
| 4194 | + | |
| 4195 | + | |
| 4196 | + | |
| 4197 | + | |
| 4198 | + | |
| 4199 | + | |
| 4200 | + | |
| 4201 | + | |
| 4202 | + | |
| 4203 | + | |
| 4204 | + | |
| 4205 | + | |
| 4206 | + | |
| 4207 | + | |
| 4208 | + | |
| 4209 | + | |
| 4210 | + | |
| 4211 | + | |
| 4212 | + | |
| 4213 | + | |
| 4214 | + | |
| 4215 | + | |
| 4216 | + | |
| 4217 | + | |
| 4218 | + | |
| 4219 | + | |
| 4220 | + | |
| 4221 | + | |
| 4222 | + | |
| 4223 | + | |
| 4224 | + | |
| 4225 | + | |
| 4226 | + | |
| 4227 | + | |
| 4228 | + | |
| 4229 | + | |
| 4230 | + | |
| 4231 | + | |
| 4232 | + | |
| 4233 | + | |
| 4234 | + | |
| 4235 | + | |
| 4236 | + | |
| 4237 | + | |
| 4238 | + | |
| 4239 | + | |
| 4240 | + | |
| 4241 | + | |
| 4242 | + | |
| 4243 | + | |
| 4244 | + | |
| 4245 | + | |
| 4246 | + | |
| 4247 | + | |
| 4248 | + | |
| 4249 | + | |
| 4250 | + | |
| 4251 | + | |
| 4252 | + | |
| 4253 | + | |
| 4254 | + | |
| 4255 | + | |
| 4256 | + | |
| 4257 | + | |
| 4258 | + | |
| 4259 | + | |
| 4260 | + | |
| 4261 | + | |
| 4262 | + | |
| 4263 | + | |
| 4264 | + | |
| 4265 | + | |
4186 | 4266 | | |
4187 | 4267 | | |
4188 | 4268 | | |
| |||
0 commit comments