Skip to content

Commit 190f200

Browse files
committed
Simplify process test.
1 parent 030f0f3 commit 190f200

1 file changed

Lines changed: 2 additions & 40 deletions

File tree

‎script/tool/test/test_dart_fixes_command_test.dart‎

Lines changed: 2 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -89,33 +89,15 @@ void main() {
8989
});
9090

9191
test('fails when dart fix test fails', () async {
92-
final RepositoryPackage packageThatFails = createFakePackage(
92+
createFakePackage(
9393
'package1',
9494
packagesDir,
9595
examples: <String>[],
9696
extraFiles: <String>['test_fixes/fix.dart', 'test_fixes/fix.dart.expect'],
9797
);
98-
packageThatFails.dartFixTestDirectory.childFile('fix.dart').writeAsStringSync('a');
99-
packageThatFails.dartFixTestDirectory.childFile('fix.dart.expect').writeAsStringSync('b');
100-
101-
final RepositoryPackage packageThatSucceeds = createFakePackage(
102-
'package2',
103-
packagesDir,
104-
examples: <String>[],
105-
extraFiles: <String>['test_fixes/fix.dart', 'test_fixes/fix.dart.expect'],
106-
);
107-
packageThatSucceeds.dartFixTestDirectory.childFile('fix.dart').writeAsStringSync('c');
108-
packageThatSucceeds.dartFixTestDirectory.childFile('fix.dart.expect').writeAsStringSync('c');
10998

11099
processRunner.mockProcessesForExecutable['dart'] = <FakeProcessInfo>[
111-
FakeProcessInfo(_MockDartFixProcess(processRunner, packagesDir.fileSystem), const <String>[
112-
'fix',
113-
'--compare-to-golden',
114-
]),
115-
FakeProcessInfo(_MockDartFixProcess(processRunner, packagesDir.fileSystem), const <String>[
116-
'fix',
117-
'--compare-to-golden',
118-
]),
100+
FakeProcessInfo(MockProcess(exitCode: 1), const <String>['fix', '--compare-to-golden']),
119101
];
120102

121103
Error? commandError;
@@ -133,28 +115,8 @@ void main() {
133115
containsAllInOrder(<Matcher>[
134116
contains('The following packages had errors:'),
135117
contains(' package1'),
136-
isNot(contains('package2')),
137118
]),
138119
);
139120
});
140121
});
141122
}
142-
143-
/// Fails when fix.dart does not equal fix.dart.expect.
144-
class _MockDartFixProcess extends MockProcess {
145-
_MockDartFixProcess(this.processRunner, this.fileSystem);
146-
final RecordingProcessRunner processRunner;
147-
final FileSystem fileSystem;
148-
149-
@override
150-
Future<int> get exitCode async {
151-
final ProcessCall call = processRunner.recordedCalls.last;
152-
final String? workingDir = call.workingDir;
153-
final File fixDart = fileSystem.file(fileSystem.path.join(workingDir!, 'fix.dart'));
154-
final File fixExpect = fileSystem.file(fileSystem.path.join(workingDir, 'fix.dart.expect'));
155-
if (!fixDart.existsSync() || !fixExpect.existsSync()) {
156-
return 1;
157-
}
158-
return fixDart.readAsStringSync() == fixExpect.readAsStringSync() ? 0 : 1;
159-
}
160-
}

0 commit comments

Comments
 (0)