Repository navigation
Commit 13d38e0
authored
[material_ui] Unskip long press drag test on web (#13358)
Follow-up to flutter/flutter#194877.
`long press drag extends the selection to the word under the drag and shows toolbar on lift on non-Apple platforms` is skipped on the web, but the only thing that actually breaks there is the drag geometry: `textOffsetToPosition` nudges the position by 1px on web, so `moveBy(const Offset(-200, 0))` lands exactly on the glyph boundary between `Peel` and the following space, and `getWordAtOffset` resolves to the whitespace instead of the word. `_expectMaterialToolbarForPartialSelection()` already handles `isContextMenuProvidedByPlatform`, so the skip is not needed once the drag targets are fixed.
This PR drags to the middle of each target word instead of relative offsets, drops the skip, and tags the test with `reduced-web-test-set` so it runs on the web shards. Verified with `flutter test`, `flutter test --platform chrome`, and `flutter test --platform chrome --wasm`.
Test-only change, so no version bump or CHANGELOG entry is needed.1 parent 8cdc6e5 commit 13d38e0
1 file changed
Lines changed: 7 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12714 | 12714 | | |
12715 | 12715 | | |
12716 | 12716 | | |
12717 | | - | |
| 12717 | + | |
| 12718 | + | |
12718 | 12719 | | |
12719 | 12720 | | |
12720 | 12721 | | |
12721 | 12722 | | |
12722 | 12723 | | |
12723 | 12724 | | |
12724 | 12725 | | |
12725 | | - | |
12726 | | - | |
| 12726 | + | |
| 12727 | + | |
12727 | 12728 | | |
12728 | 12729 | | |
12729 | 12730 | | |
12730 | 12731 | | |
12731 | 12732 | | |
12732 | 12733 | | |
12733 | 12734 | | |
12734 | | - | |
| 12735 | + | |
| 12736 | + | |
12735 | 12737 | | |
12736 | 12738 | | |
12737 | 12739 | | |
| |||
12750 | 12752 | | |
12751 | 12753 | | |
12752 | 12754 | | |
12753 | | - | |
| 12755 | + | |
12754 | 12756 | | |
12755 | 12757 | | |
12756 | 12758 | | |
| |||
0 commit comments