Skip to content

Commit 0e3b726

Browse files
authored
[ci] Increase check-discovery timeout in release workflows (#13392)
Post-submit `release.yml` runs on `main` have been regularly flaking at `Wait for test check-in` with: ``` Matching checks have not been found yet, will check again in 30 seconds. (Limit: 60s) The requested check was never run against this ref, exiting... ``` When a PR merges to `main`, Cocoon cannot register post-submit LUCI check-runs until the commit mirrors from GitHub to Git-on-Borg, relying on Cloud Pub/Sub exponential backoff retries (up to 15 minutes). That routinely takes ~3–4 minutes, losing the race against `lewagon/wait-on-check-action`'s default 60-second `checks-discovery-timeout` (often by just 3–7 seconds). This PR sets `checks-discovery-timeout: 900` (15 minutes, matching Cocoon's Git-on-Borg sync window) on `Wait for test check-in` in `release.yml` (and in `reusable_release.yml` to keep them in sync). Follow-up PRs will address blocking `auto-submit` when a release workflow fails and guarding against version gaps in repo tooling. Part of flutter/flutter#194870 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent f5dc255 commit 0e3b726

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ jobs:
4747
check-name: 'Linux ci_yaml packages roller'
4848
repo-token: ${{ secrets.GITHUB_TOKEN }}
4949
wait-interval: 30 # seconds
50+
# Cocoon waits up to 15 minutes for commits to mirror to Git-on-Borg
51+
# before registering post-submit LUCI checks.
52+
checks-discovery-timeout: 900 # seconds
5053
allowed-conclusions: success,neutral
5154
# verbose:true will produce too many logs that hang github actions web UI.
5255
verbose: false

‎.github/workflows/reusable_release.yml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ jobs:
5757
check-name: 'Linux ci_yaml packages roller'
5858
repo-token: ${{ secrets.GITHUB_TOKEN }}
5959
wait-interval: 30 # seconds
60+
# Cocoon waits up to 15 minutes for commits to mirror to Git-on-Borg
61+
# before registering post-submit LUCI checks.
62+
checks-discovery-timeout: 900 # seconds
6063
allowed-conclusions: success,neutral
6164
# verbose:true will produce too many logs that hang github actions web UI.
6265
verbose: false

0 commit comments

Comments
 (0)