-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update compileSdkVersion to 31 and gradle lockfiles #557
Conversation
guidezpl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
The |
|
flutter/flutter#93117 reland PR depends on this PR. |
|
@amanv8060 Please try the latest flutter master and let me know if you still can't compile. |
|
@andreidiaconu Thanks, I can now run now, it's weird but I tried earlier and was unable to build the app with errors
I don't remember exactly which flutter/flutter commit I was on when I faced this issue. Also, See similar prob here : #558 |
|
Thank you for also posting the actual error. I can now confirm my initial hunch: This PR updated the gallery repo to be compatible with the newest flutter master, but because that is how gradle lockfiles work, it also means that the repo is incompatible with older versions of flutter. I think this happens every time the lockfiles need to be updated, but maybe maintainers of this repo can confirm. The reason why you had problems using flutter master until today is that the flutter change that required this PR hit a few bumps in the road, got reverted, relanded, etc - but it is now merged correctly and as long as you use flutter master for a while (until Display Features flutter/engine#29585 are promoted to other channels) you should not see this issue. |
flutter/flutter#89511 requires
compileSdkVersion 31and it also introduces new android dependencies which means the gradle lockfiles need to be updated.Helps with relanding flutter/flutter#89511 which was reverted in flutter/flutter#93098
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
///).