This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Remove the AnimatedSize vsync parameter #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
approved these changes
Apr 21, 2021
Contributor
rami-a
left a comment
rami-a
left a comment
There was a problem hiding this comment.
LGTM but have a couple questions
| key: _expandingBottomSheetKey, | ||
| duration: const Duration(milliseconds: 225), | ||
| curve: Curves.easeInOut, | ||
| vsync: this, |
Contributor
There was a problem hiding this comment.
Would this class still need to be a TickerProviderStateMixin
Member
Author
There was a problem hiding this comment.
Removed the TickerProviderStateMixin
| ); | ||
| } else { | ||
| section = AnimatedSize( | ||
| vsync: this, |
Contributor
There was a problem hiding this comment.
Would this class still need to be a TickerProviderStateMixin?
Member
Author
There was a problem hiding this comment.
This is still needed because _GalleryDemoPageState is also creating an AnimationController that uses a TickerProvider
This is needed in order to land flutter/flutter#80554, which will deprecate AnimatedSize.vsync
jason-simmons
force-pushed
the
deprecate_vsync
branch
from
0b5bcb1 to
9817044
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in order to land flutter/flutter#80554,
which will deprecate AnimatedSize.vsync