Skip to content

Conversation

@stevemessick
Copy link
Member

@stevemessick stevemessick commented Jun 25, 2021

Screen Shot 2021-07-12 at 4 08 25 PM

Fixes #2334

@google-cla google-cla bot added the cla: yes label Jun 25, 2021
@stevemessick stevemessick force-pushed the dynamic-icon-preview branch from 60b769b to 3456166 Compare July 12, 2021 23:16
@stevemessick stevemessick force-pushed the dynamic-icon-preview branch from 392976c to 16dd0ec Compare July 14, 2021 17:39
@stevemessick stevemessick changed the title [WiP] Dynamic icon preview of non-standard icon packages Dynamic icon preview of non-standard icon packages Jul 14, 2021
@mzdm
Copy link
Contributor

mzdm commented Jul 14, 2021

As an icon package owner as well, will I need to do some modification in the code and/or letting users know in README how to set this up or will it be automatically?

@stevemessick
Copy link
Member Author

@mzdm Good question. I'll have instructions in the release notes next month, with screen shots.

As an icon package owner as well, will I need to do some modification in the code and/or letting users know in README how to set this up or will it be automatically?

Each project has to configure the icon packs it wants to see previews for. There is a new text field in the preferences/settings page for the Flutter plugin for that. I may be able to eliminate that, and analyze the pubspec.yaml but ran out of time to fully investigate that. Adding instructions to your package would help get the word out.

@stevemessick
Copy link
Member Author

Here's a screen shot of the new text pane, showing all the icon packages that are known to work. I know of three that do not work, and warn users about them (flutter_icons, flutter_vector_icons, material_design_icons_flutter).

Screen Shot 2021-07-14 at 1 55 29 PM

@mzdm
Copy link
Contributor

mzdm commented Jul 14, 2021

@stevemessick Great, thanks! I'll be watching the future commits/release notes for instructions. 👍

@jwren
Copy link
Member

jwren commented Jul 16, 2021

LGTM

@jwren jwren self-requested a review July 16, 2021 02:59
@stlr00
Copy link

stlr00 commented Dec 14, 2021

Still doesnt work with my custom icons from FlutterIcon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show Icons for Custom Icon Packages

4 participants