Show notification on error with deep link - #5207

instead of doing a string search, should we do URI parsing instead and then grab the query param value at 'inspectorRef'?

Weirdly I can't seem to get a query string from the URL. e.g.

final URI uri = new URI(urlString);
final String[] paramPairs = uri.getQuery() // this is null

maybe because of the # after the port? I'm not sure. Certainly it would be nicer to use more standard parsing, if anyone has suggestions on this.

when we see a DevToolsDeepLinkProperty does this early return guarantee that we don't show the deep link url in the intellij console?

Right, the early return skips printing in the console. I could add a short description like "Click on notification to inspect widget" or something like that.

@csells @InMatrix for input on verbiage

@DanTup sent an example over to me that looked like this:

I think we should try to use consistent wording between the two IDEs, and I actually like how in this screenshot it just grabs the error message directly from the error, so it's consistent with console output as well.

For the button text, I like "Inspect widget"

Updated to look like this:

There's a title as well as the button, let me know if any of you have preferences there.

maybe change the title text to "Inspect error-causing widget"?

this wording matches what the error message says. For example,

The relevant error-causing widget was:
  Column
  file:///Users/kenzieschmoll/develop/flutter_vignettes/vignettes/spending_tracker/lib/demo.dart:64:26

Sure, like this?

I'll land with the current lame URL parsing and make updates in a later PR if there's a nicer way.

I'm late to the party. The verbiage looks fine. I like the icon in the VS Code version more than the Flutter icon in the IntelliJ version, which signals that this notification is related to an error. For the IntelliJ version, can we go without a title for the message to match the simplicity of the VS Code version?

A related question: how are we handling multiple exceptions thrown at the same time? Will the user get a bunch of notifications at once? For example, this Missing Material Widget error will also generate a RenderFlex Overflow error from the red warning screen on device.

I'm making another change for the length of time this notification is shown, so I can make the other adjustments there too.

If there are multiple exceptions, they'll show up stacked like this:

Will the first error get displayed at the top of the stack or the bottom? The first error is usually relevant to the user's code in my experience.

Hmm it's the most recent error that gets displayed. When "1 more" is clicked, there's a list shown of all the notifications with their timestamps:

It may be the IntelliJ default to show the most recent at the top so that new notifications aren't missed. I can check whether this can be adjusted for a particular group of errors.

Thanks for checking. I think we need to try it over a few example errors and determine what makes sense. Flutter framework often throws secondary exceptions down the pipeline caused by the primary error the user can fix in their own code. Maybe there are other filtering strategies we can employ.