Skip to content

Add Diagnosticable mixin to ButtonStyleButton buttons #99976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TahaTesser wants to merge 2 commits into from
Closed

Add Diagnosticable mixin to ButtonStyleButton buttons #99976

TahaTesser wants to merge 2 commits into from

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Mar 11, 2022 •
edited
Loading

fixes #99975

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 11, 2022
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@TahaTesser TahaTesser force-pushed the material_buttons_diagnosticable branch from 166772f to 69f3be1 Compare March 15, 2022 07:50
@HansMuller HansMuller requested a review from gspencergoog March 18, 2022 22:01
@TahaTesser TahaTesser force-pushed the material_buttons_diagnosticable branch from 69f3be1 to a105844 Compare March 21, 2022 08:47
@skia-gold

This comment was marked as resolved.

Sign in to view
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 21, 2022
@TahaTesser TahaTesser removed the will affect goldens Changes to golden files label Mar 22, 2022
HansMuller
HansMuller reviewed Mar 22, 2022
View reviewed changes
@TahaTesser TahaTesser force-pushed the material_buttons_diagnosticable branch from a9fcd07 to a5794ae Compare May 2, 2022 10:11
@TahaTesser

This comment was marked as outdated.

Sign in to view
@TahaTesser TahaTesser closed this May 9, 2022
@TahaTesser TahaTesser deleted the material_buttons_diagnosticable branch May 9, 2022 18:09
@TahaTesser TahaTesser mentioned this pull request May 9, 2022
Closed
@TahaTesser TahaTesser removed the request for review from gspencergoog May 9, 2022 18:10
@TahaTesser TahaTesser mentioned this pull request May 9, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog left review comments

+1 more reviewer

@HansMuller HansMuller HansMuller left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide Diagnosticable mixin to ButtonStyleButton buttons

4 participants

@TahaTesser @skia-gold @HansMuller @gspencergoog