[flutter_tools] check if stream is open before sending message in ios device #99947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
christopherfujino
force-pushed
the
close-stream
branch
from
1f123b9 to
1430f35
Compare
christopherfujino
changed the title
christopherfujino
changed the title
| onError: _linesController.addError, | ||
| onDone: _linesController.close, | ||
| (String line) { | ||
| if (!linesController.isClosed) { |
Contributor
Author
There was a problem hiding this comment.
This is the actual fix, the other added if checks are just defensive.
Member
There was a problem hiding this comment.
Why here and not in e.g. _newSyslogLineHandler(), or up on line 697?
Contributor
Author
There was a problem hiding this comment.
Were there multiple stacktraces we're seeing in CI, or is this a more general question? The stacktraces I saw where all on line 719.
Should I wrap the StreamController so that every .add() call has a check first if the delegate is closed?
Contributor
Author
There was a problem hiding this comment.
Or I can add a new method on the IOSDeviceLogReader class
zanderso
approved these changes
Mar 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99021
Related to #99406
Related to #98421
Related to #99855