docs: Add more potential use case for Bottom Navigation Bar #99644

amanv8060 · 2022-03-06T20:41:06Z

Adds the dartpad example for the use case mentioned in the issue

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

amanv8060 · 2022-05-02T19:26:44Z

@HansMuller does this pr need additional changes?

packages/flutter/lib/src/material/bottom_navigation_bar.dart

HansMuller · 2022-06-03T15:09:36Z

The new examples system requires a tests for each example. They can be simple basic functionality unit tests. See for example examples/api/test/material/appbar/app_bar.0_test.dart

guidezpl

Thanks for contributing! I like the example for scrolling to top, but using bottom nav to change state is a bit of an anti-pattern.

It would be more useful to showcase an example like "having a unique item that doesn't update the selectedIndex (ie. a button that opens a dropdown or modal instead of updating the displayed Scaffold.body)"

guidezpl · 2022-06-13T17:02:02Z

examples/api/lib/material/bottom_navigation_bar/bottom_navigation_bar.2.dart

+          onTap: (int index) {
+            switch (index) {
+              case 0:
+                _homeController.animateTo(


This should only scroll if the selected tab is index

I'm still seeing _selectedIndex == 0, perhaps you need to push?

Should be fine now.

auto-submit · 2022-06-23T10:39:06Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T10:47:06Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T10:49:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T11:05:06Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T11:07:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T14:33:06Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T14:41:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T14:47:06Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T14:49:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T15:07:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T15:45:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T15:49:10Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T15:53:08Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T15:59:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T16:05:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T16:25:06Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T16:45:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T16:53:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T16:55:09Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T17:05:08Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T17:07:10Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T17:11:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2022-06-23T17:13:07Z

Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

jonahwilliams

RSLGTM

…lutter/flutter#99644)

…99644)

…lutter/flutter#99644)

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 6, 2022

amanv8060 force-pushed the 33810 branch from dd77420 to 39e2b01 Compare March 7, 2022 02:37

HansMuller self-requested a review March 18, 2022 23:09

guidezpl requested changes Jun 3, 2022

View reviewed changes

packages/flutter/lib/src/material/bottom_navigation_bar.dart Outdated Show resolved Hide resolved

amanv8060 added 5 commits June 11, 2022 04:24

Add Example

6bdcec5

fix style

144fc55

Fix analysis issue

d33ce54

move example to examples

ff12058

add test for bottom_navigation_bar.2.dart

f0c2b4a

amanv8060 force-pushed the 33810 branch from 39e2b01 to f0c2b4a Compare June 11, 2022 15:27

amanv8060 requested a review from guidezpl June 11, 2022 15:27

guidezpl requested changes Jun 13, 2022

View reviewed changes

amanv8060 force-pushed the 33810 branch from 01e2c9c to 62c59c6 Compare June 19, 2022 12:15

amanv8060 requested a review from guidezpl June 19, 2022 12:18

guidezpl approved these changes Jun 23, 2022

View reviewed changes

guidezpl added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2022

feat: change example to show dialog

afe7ce4

amanv8060 force-pushed the 33810 branch from 539205b to afe7ce4 Compare June 23, 2022 10:48

flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 23, 2022

jonahwilliams approved these changes Jun 23, 2022

View reviewed changes

auto-submit bot merged commit 3022db2 into flutter:master Jun 23, 2022

amanv8060 deleted the 33810 branch June 23, 2022 17:19

This was referenced Jun 24, 2022

Roll Flutter from a30012b27505 to 6c3a0e4d21da (6 revisions) flutter/plugins#6037

Merged

Roll Flutter from fe41b6abcd53 to 6c3a0e4d21da (5 revisions) flutter/packages#2277

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 24, 2022

3022db2 docs: Add more potential use case for Bottom Navigation Bar (f…

443fe02

…lutter/flutter#99644)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2022

3022db2 docs: Add more potential use case for Bottom Navigation Bar (f…

728e712

…lutter/flutter#99644)

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

docs: Add more potential use case for Bottom Navigation Bar (flutter#…

fc7ed08

…99644)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022

3022db2 docs: Add more potential use case for Bottom Navigation Bar (f…

addb55c

…lutter/flutter#99644)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022

3022db2 docs: Add more potential use case for Bottom Navigation Bar (f…

6f034f8

…lutter/flutter#99644)

Piinks mentioned this pull request Dec 10, 2024

[Documentation] Additional BottomNavigationBar use cases through samples #33810

Closed

docs: Add more potential use case for Bottom Navigation Bar #99644

docs: Add more potential use case for Bottom Navigation Bar #99644

Uh oh!

Conversation

amanv8060 commented Mar 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

amanv8060 commented May 2, 2022

Uh oh!

Uh oh!

HansMuller commented Jun 3, 2022

Uh oh!

guidezpl left a comment

Choose a reason for hiding this comment

Uh oh!

guidezpl Jun 13, 2022

Choose a reason for hiding this comment

Uh oh!

amanv8060 Jun 19, 2022

Choose a reason for hiding this comment

Uh oh!

guidezpl Jun 20, 2022

Choose a reason for hiding this comment

Uh oh!

amanv8060 Jun 23, 2022

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

auto-submit bot commented Jun 23, 2022

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

amanv8060 commented Mar 6, 2022 •

edited

Loading