Skip to content

Add version to xcode name cache. #99586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
godofredoc merged 1 commit into from
Mar 5, 2022
Merged

Add version to xcode name cache. #99586

godofredoc merged 1 commit into from
Mar 5, 2022

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Mar 5, 2022

Engine and Flutter using different xcode versions with the same cache
name is causing multiple problems when trying to find the runtimes. To
prevent this issue we will need to use different cache names for
different xcode versions.

Bug: #99429

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Add version to xcode name cache.
db8edec 
Engine and Flutter using different xcode versions with the same cache
name is causing multiple problems when trying to find the runtimes. To
prevent this issue we will need to use different cache names for
different xcode versions.

Bug: #99429
@godofredoc godofredoc requested review from jmagman and zanderso March 5, 2022 05:45
@godofredoc godofredoc merged commit ea0b771 into flutter:master Mar 5, 2022
@godofredoc godofredoc deleted the fix_caches branch March 5, 2022 06:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
48110b5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
92b3f3b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
ac80933
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
f2f04ff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
d18beb9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
48e587d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
b74489b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 5, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
acb7a8f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
dc35291
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
abd63f7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
6be0cc9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
dab766a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
909d5b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
995fc1d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
a2d3cdf
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
5da2c2a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
022dc6a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
55f72b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
7974667
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
47e137f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
5ea1642
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
fd9b277
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
cd4af57
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
3675f46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
9bef385
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
a7502d7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
dd4dab5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
33d4bf4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
c06da18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
bcbb43c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
e92514e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
35688b3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
69d8d12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
8811f16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
cce0ead
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
b26e6c3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
5f87ee0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
a470f22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
ea0b771 Add version to xcode name cache. (flutter/flutter#99586)
dfc24ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@zanderso zanderso zanderso approved these changes

@keyonghan keyonghan Awaiting requested review from keyonghan

@CaseyHillers CaseyHillers Awaiting requested review from CaseyHillers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @jmagman @zanderso