Skip to content

Conversation

@TahaTesser
Copy link
Member

part of #86174

Complete details #86174 (comment)

Integration test for web results:

CupertinoSlider

Launching integration_test/cupertino/cupertino_slider.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_slider.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui
This app is linked to the debug service: ws://127.0.0.1:64234/ZBUel3Ws8lU=/ws
Debug service listening on ws://127.0.0.1:64234/ZBUel3Ws8lU=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:64234/ZBUel3Ws8lU=/ws
00:00 +0: Hovering over Cupertino slider thumb updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Mar 4, 2022
@TahaTesser TahaTesser changed the title CupertinoSlider: Add clickable cursor for web CupertinoSlider: Add clickable cursor for web Mar 4, 2022
@TahaTesser
Copy link
Member Author

cc: @Renzo-Olivares

Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out, this LGTM. I was curious why you did this one with MouseTrackerAnnotation instead of MouseRegion like the other cupertino widgets but I see why now. That would make the entire slider visually clickable and not just the handle. Sorry for the delay, this needs a rebase.

@TahaTesser TahaTesser force-pushed the cupertino_slider_web_cursor branch from 80bbe3b to 7e13d79 Compare June 8, 2022 07:09
@fluttergithubbot fluttergithubbot merged commit d72daf6 into flutter:master Jun 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 8, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 8, 2022
@TahaTesser TahaTesser deleted the cupertino_slider_web_cursor branch June 9, 2022 11:27
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants