-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[ci.yaml] Mac web_tool_tests force cache clear via 98.1 #99517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@godofredoc I see: However, Mac web_tool_tests fails with: Is there another place I need to push the tag? |
| [ | ||
| {"dependency": "android_sdk", "version": "version:31v8"}, | ||
| {"dependency": "chrome_and_driver", "version": "version:98"}, | ||
| {"dependency": "chrome_and_driver", "version": "version:98.1"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update all the references of version:98 to version:98.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
This is another signal that we should stop using CIPD tags or refs. They are footguns. If we want to tag a version, it's trivial to use a named variable-like construct, such as: variables:
chrome98: suCE89Njm7T4C2poqhfGK2Lgm3BBS7JL46e6wIv-WgMC
...
dependencies:
chrome_and_driver: $chrome98 |
|
Looks correctly tagged: |
|
There was an issue in the retried build (it didn't pass 98.1). I filed #99523 as this is a bug in cocoon |
|
This pull request is not suitable for automatic merging in its current state.
|
#99372 (comment)