Skip to content

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers requested a review from godofredoc March 3, 2022 23:08
@CaseyHillers CaseyHillers requested a review from keyonghan as a code owner March 3, 2022 23:08
@CaseyHillers
Copy link
Contributor Author

@godofredoc I see:

chillers@chillzone:~/flutter$ cipd describe flutter_internal/browsers/chrome/mac-amd64 -version BlBCql9ZngKYkn_tiqUUCnZKtZtbbCnsP0RgmLIn2ZwC
Package:       flutter_internal/browsers/chrome/mac-amd64
Instance ID:   BlBCql9ZngKYkn_tiqUUCnZKtZtbbCnsP0RgmLIn2ZwC
Registered by: user:[email protected]
Registered at: 2022-03-01 12:23:12.778879 -0800 PST
Refs:          none
Tags:
  version:98.1
  version:98

However, Mac web_tool_tests fails with: CIPD('ensure_installed') failed with: failed to resolve flutter_internal/browser-drivers/chrome/mac-amd64@version:98.1 (line 1): no such tag

Is there another place I need to push the tag?

[
{"dependency": "android_sdk", "version": "version:31v8"},
{"dependency": "chrome_and_driver", "version": "version:98"},
{"dependency": "chrome_and_driver", "version": "version:98.1"},
Copy link
Contributor

@godofredoc godofredoc Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update all the references of version:98 to version:98.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@yjbanov
Copy link
Contributor

yjbanov commented Mar 4, 2022

This is another signal that we should stop using CIPD tags or refs. They are footguns. If we want to tag a version, it's trivial to use a named variable-like construct, such as:

variables:
  chrome98: suCE89Njm7T4C2poqhfGK2Lgm3BBS7JL46e6wIv-WgMC
...
dependencies:
  chrome_and_driver: $chrome98

@ditman
Copy link
Member

ditman commented Mar 4, 2022

Looks correctly tagged:

$ cipd search flutter_internal/browsers/chrome/mac-amd64 -tag version:98.1
Instances:
  flutter_internal/browsers/chrome/mac-amd64:BlBCql9ZngKYkn_tiqUUCnZKtZtbbCnsP0RgmLIn2ZwC

@CaseyHillers
Copy link
Contributor Author

There was an issue in the retried build (it didn't pass 98.1). I filed #99523 as this is a bug in cocoon

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CaseyHillers CaseyHillers merged commit ae9a796 into flutter:master Mar 4, 2022
@CaseyHillers CaseyHillers deleted the cipd branch March 4, 2022 03:11
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants