Skip to content

complete migration of flutter repo to Object.hash* #99505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Mar 4, 2022
Merged

complete migration of flutter repo to Object.hash* #99505

fluttergithubbot merged 3 commits into from
Mar 4, 2022

Conversation

@werainkhatri
Copy link
Member

@werainkhatri werainkhatri commented Mar 3, 2022 •
edited
Loading

migrates a few places still using hashValues and hashList.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@werainkhatri werainkhatri requested a review from Hixie March 3, 2022 19:48
@werainkhatri werainkhatri requested a review from Piinks as a code owner March 3, 2022 19:48
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 3, 2022
@werainkhatri werainkhatri mentioned this pull request Mar 3, 2022
Merged
13 tasks
@goderbauer
Copy link
Member

goderbauer commented Mar 3, 2022

@werainkhatri Looks like some checks are failing. Can you please take a look?

@goderbauer goderbauer self-requested a review March 3, 2022 21:43
goderbauer
goderbauer approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cbracken
cbracken approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

justinmc
justinmc approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fluttergithubbot fluttergithubbot merged commit 671aa9e into flutter:master Mar 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
c05b9c9 
…lutter#99505)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
c199219 
…lutter#99505)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
d469298 
…lutter#99505)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
78c2d6c 
…lutter#99505)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
b3ea38a 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
89061de 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
71d859d 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
29920bf 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
09e15c9 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
3b772b2 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
378174c 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
c557c7e 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
e940d3d 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
7f466b9 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
2f8cc8e 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
94ff866 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
e769d0a 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
ca95097 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
bdd1a17 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
e4f7083 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
d70d830 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
c9d7dec 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
be0cb17 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
45be775 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
b3b4a84 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
3858595 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
6f6bfae 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
a7870c0 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
3915a25 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
d05f14a 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
b9ee0ec 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
3faa720 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
d77e557 
…lutter#99505)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
671aa9e complete migration of flutter repo to Object.hash* (flutter/f…
1fc894d 
…lutter#99505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@justinmc justinmc justinmc approved these changes

@goderbauer goderbauer goderbauer approved these changes

@Hixie Hixie Awaiting requested review from Hixie

@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@werainkhatri @goderbauer @cbracken @justinmc @fluttergithubbot