Skip to content

Use PlatformDispatcher.instance over window where possible #99496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 3, 2022
Merged

Use PlatformDispatcher.instance over window where possible #99496

fluttergithubbot merged 1 commit into from
Mar 3, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 3, 2022

Similar to #99443, but focused on direct usage of dart:ui's window global and moves those usages to PlatformDispatcher.instance.

Where appropriate, the PR also moves away from using the globals exposed by dart:ui directly and instead accesses the window/platformDispatcher via the Binding as recommended in the docs [1] and [2].

Part of #60131 to work towards #30701.

[1] https://master-api.flutter.dev/flutter/dart-ui/window.html
[2] https://master-api.flutter.dev/flutter/dart-ui/PlatformDispatcher/instance.html

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: internationalization Supporting other languages or locales. (aka i18n) a: text input Entering text in a text field or keyboard related problems d: examples Sample code and demos f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 3, 2022
@goderbauer goderbauer changed the title Use PlatformDispatcher.instance over window where possible Use PlatformDispatcher.instance over window where possible Mar 3, 2022
@goderbauer goderbauer requested a review from gspencergoog March 3, 2022 18:30
gspencergoog
gspencergoog approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

It's good to see this!

Are you planning to deprecate window too?

@goderbauer
Copy link
Member Author

goderbauer commented Mar 3, 2022

Are you planning to deprecate window too?

Long term that's the plan. Need to have a new way to get your current window first, though (e.g. via an InheritedWidget or something).

@fluttergithubbot fluttergithubbot merged commit 7f2c1cd into flutter:master Mar 3, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
24aa69f 
flutter/flutter#99496)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
a29304a 
flutter/flutter#99496)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
baa98c6 
flutter/flutter#99496)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
d8e6df6 
flutter/flutter#99496)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
870be73 
flutter/flutter#99496)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
f1922e1 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
a3c221d 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
c67218b 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
2868cea 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
79c9875 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
108c9dc 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
dbf41f5 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
1c2472f 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
c079155 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
0560d39 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
e7132cf 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
c5f63e9 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
0148dc4 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
0a065a1 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
24385a2 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
8a5c50e 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
0aa61f5 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
042fc8f 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
8ffb5d7 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
0931242 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
06a3c45 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
7a3e2c6 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
b2d1f98 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
13395df 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
7c8d411 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
ab521bc 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
54f5dff 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
ae6d18c 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
3f55764 
flutter/flutter#99496)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
7f2c1cd Use PlatformDispatcher.instance over window where possible (
47bf4bb 
flutter/flutter#99496)
@goderbauer goderbauer deleted the globalWindow branch March 3, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: internationalization Supporting other languages or locales. (aka i18n) a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

Multi Window
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @gspencergoog @fluttergithubbot