Skip to content

Deflake post-submit Linux/Samsung S10 tests #99454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 3, 2022
Merged

Deflake post-submit Linux/Samsung S10 tests #99454

fluttergithubbot merged 1 commit into from
Mar 3, 2022

Conversation

@keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Mar 3, 2022

These tests have been validated in the staging pool for more than 50 runs (e.g. backdrop_file_perf__timeline_summary), and were newly enabled in prod as bringup: true (#99353).

Now tests are running successfully, this PR is removing bringup: true flag.

@keyonghan keyonghan requested a review from CaseyHillers as a code owner March 3, 2022 05:07
@keyonghan keyonghan requested a review from zanderso March 3, 2022 19:08
@fluttergithubbot fluttergithubbot merged commit 3417394 into flutter:master Mar 3, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
dd8b0a4 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
394f434 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
d54ae58 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
868c8a7 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
bef76f3 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
3c9c718 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
3f1b4dd 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
83fa500 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
f2240f2 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
ba2695b 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
fbfb908 
…99454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
8911a98 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
10ce44f 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
447748a 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
da2f036 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
92a6e5d 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
e748b5b 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
97b8f17 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
838826c 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
bbf38aa 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
1a818ff 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
a5b4745 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
4fc1cd9 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
bf7a706 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
b76de4b 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
bd86c96 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
2fa1fa1 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
e2a5d5b 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
f56171e 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
1602f85 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
c2e4432 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
5071307 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
cdf4cf5 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
77aa117 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
02f61d5 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
b4093d2 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
a0dc5f8 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
b76e32b 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
73e8ad1 
…99454)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
3417394 Deflake post-submit Linux/Samsung S10 tests (flutter/flutter#…
92b8c59 
…99454)
@keyonghan keyonghan deleted the promote_samsung_tests_to_prod branch April 25, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@keyonghan @CaseyHillers @zanderso @fluttergithubbot