Skip to content

Use BindingBase.platformDispatcher over BindingBase.window where possible #99443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 7 commits into from
Mar 4, 2022
Merged

Use BindingBase.platformDispatcher over BindingBase.window where possible #99443

fluttergithubbot merged 7 commits into from
Mar 4, 2022

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Mar 3, 2022 •
edited
Loading

This is in preparation for multi-window support and removes the bias towards a single window from some of the framework code. There's still more work to do...

This PR basically removes SingletonFlutterWindow from the framework (with the exception of the still existing BindingBase.window and TestWindow from flutter_test - but all code now treats them as being regular FlutterViews and doesn't rely on any of the additional backwards-compatibility functionality that SingletonFlutterWindow provides over FlutterView).

Part of #60131 to work towards #30701.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels. labels Mar 3, 2022
@goderbauer goderbauer requested a review from gspencergoog March 3, 2022 16:58
@goderbauer goderbauer mentioned this pull request Mar 3, 2022
Merged
@goderbauer goderbauer changed the title Use BindingBase.platformDispatcher over BindingBase.window where possible Use BindingBase.platformDispatcher over BindingBase.window where possible Mar 3, 2022
gspencergoog
gspencergoog approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

I like the factoring out of the test platform dispatcher.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 4, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 852bfe2 into flutter:master Mar 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
6f30b2d 
…` where possible (flutter/flutter#99443)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
cf1527e 
…` where possible (flutter/flutter#99443)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
9e89ee3 
…` where possible (flutter/flutter#99443)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
3da7878 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
b82217d 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
e0748df 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
b805232 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
2a6ab50 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
fbba989 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
a302445 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
0c423f0 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
253a07c 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
feff9a7 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
17a87f5 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
9b2857e 
…` where possible (flutter/flutter#99443)
@xuzhongpeng
Copy link

xuzhongpeng commented Mar 14, 2022

Are there any examples of use？

Look at the files changed by this PR. They all show examples of how to use the platform dispatcher.

Are there any PRs to support for macos now.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
d48829a 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
ad25960 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
f769fba 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
7776236 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
90c8bb4 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
aff6315 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
609ca02 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
3ea5831 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
e2d4ffa 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
4975028 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
3a4a7df 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
a990641 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
610028b 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
596243b 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
858670a 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
1158c00 
…` where possible (flutter/flutter#99443)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
852bfe2 Use BindingBase.platformDispatcher over `BindingBase.window…
61ddda4 
…` where possible (flutter/flutter#99443)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

Multi Window
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@goderbauer @fluttergithubbot @xuzhongpeng @gspencergoog