Skip to content

Fix lifecycle for API level 28 #99433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blasten merged 3 commits into from
Mar 3, 2022
Merged

Fix lifecycle for API level 28 #99433

blasten merged 3 commits into from
Mar 3, 2022

Conversation

@blasten
Copy link

@blasten blasten commented Mar 2, 2022

I'm seeing a different flow of lifecycle events in the device lab.

The device lab runs API level 28.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Mar 2, 2022
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 2, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@blasten blasten merged commit f320d14 into flutter:master Mar 3, 2022
@blasten blasten deleted the android_lifecycle_api_28 branch March 3, 2022 02:30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
efd75e6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
5c8859e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
0401523
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
53feb62
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
47cf907
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
8272a2b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
26914b1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
a27aa3f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
88f312d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
4373a89
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
d507468
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
c548cac
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
92085ae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
0a06e2a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
5be591c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
d652441
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
f37493f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
fcaa591
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
6740385
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
a255bab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
0f9c464
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
8e2ef39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
16fd987
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
d139320
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
15f3da3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
114e15c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
bcd90b7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
6fc92eb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
f24e93f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
4c681ca
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
02cb4f6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
ef2df36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
2415013
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
86b9b3e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
f86de65
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
8df8541
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
775e77e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f320d14 Fix lifecycle for API level 28 (flutter/flutter#99433)
330d4e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

@GaryQian GaryQian Awaiting requested review from GaryQian

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blasten @fluttergithubbot @jason-simmons