Skip to content

Fix the race condition in cache_test.dart #99423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gspencergoog merged 1 commit into from
Mar 3, 2022
Merged

Fix the race condition in cache_test.dart #99423

gspencergoog merged 1 commit into from
Mar 3, 2022

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Mar 2, 2022 •
edited
Loading

Description

This fixes a race condition in test/integration.shard/cache_test.dart which allowed the test to fail if the machine took a very long time to acquire a lock or launch a process.

Related Issues

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 2, 2022
@gspencergoog gspencergoog requested a review from zanderso March 2, 2022 18:28
@gspencergoog gspencergoog mentioned this pull request Mar 2, 2022
Closed
1 task
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 3, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso
Copy link
Member

zanderso commented Mar 3, 2022

The Google testing failures were unrelated, so I set the status to passing.

@gspencergoog gspencergoog merged commit fa68ecf into flutter:master Mar 3, 2022
@gspencergoog gspencergoog deleted the fix_cache_test branch March 3, 2022 20:55
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
0562d3c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
1196b1c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
a9bf4a1 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
d4c6ea1 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
73cf69d 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
1313a53 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
a9e1655 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
46c1d54 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 4, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
20ab9a7 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
4a0bc34 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
6d630d7 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
68d6d28 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
6c7e6a5 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
36381e7 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
bd37d25 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
3bd1bea 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
c544664 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
fb2a17a 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
9857961 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
dcdf9c6 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
b51411a 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
4c881e1 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
7af00b2 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
d2c0856 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
d2f04b4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
06123df 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
bebdf7b 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
21da5a8 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
a5dfb9b 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
6efff4f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
fca432c 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
c9f5279 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
ca438e4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
bfb2421 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
f345807 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
7c77fd8 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
65cf1e4 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
dc5a593 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
fa68ecf Fix the race condition in cache_test.dart (flutter/flutter#99423
13dbc7e 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Linux tool_integration_tests_4_4 flakes on cache_test

3 participants

@gspencergoog @fluttergithubbot @zanderso