Skip to content

Revert "Draggable can be accepted when the data is null" #99419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 2, 2022
Merged

Revert "Draggable can be accepted when the data is null" #99419

fluttergithubbot merged 1 commit into from
Mar 2, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 2, 2022

Reverts #97355

cc @xu-baolin It turns out changing that function signature did break a few things that did not come up in initial testing.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 2, 2022
@Piinks Piinks requested a review from renyou March 2, 2022 17:29
@fluttergithubbot fluttergithubbot merged commit f8eee10 into master Mar 2, 2022
@fluttergithubbot fluttergithubbot deleted the revert-97355-xbl000127 branch March 2, 2022 18:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
dd77ab8 
…tter/flutter#99419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
da29ca7 
…tter/flutter#99419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
6db3be9 
…tter/flutter#99419)
renyou pushed a commit to renyou/flutter that referenced this pull request Mar 2, 2022
@Piinks @renyou
Revert "Draggable can be accepted when the data is null" (flutter#99419)
ab5a743
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
c17e92a 
…tter/flutter#99419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
572a971 
…tter/flutter#99419)
renyou added a commit that referenced this pull request Mar 2, 2022
@renyou @chunhtai @Piinks
Flutter 2.12 candidate.3 (#99426)
79a0aad 
* Revert "Clean up ClipboardStatusNotifier (#98951)" (#99361)

This reverts commit c74a646.

* Revert "Draggable can be accepted when the data is null" (#99419)

Co-authored-by: chunhtai <[email protected]>
Co-authored-by: Kate Lovett <[email protected]>
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
773ac79 
…tter/flutter#99419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
a2a0d21 
…tter/flutter#99419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
7616bac 
…tter/flutter#99419)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
1cb26ef 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
126579f 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
67dc0a1 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
6bcdfec 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
5bdfa94 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
5eb41eb 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
046ea7f 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
243ca5f 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
14fd079 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
28e0708 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
18fe8d3 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
75f5166 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
bb2b1c7 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
ef6de08 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
ccdabe9 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
d13dcc2 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
9c3168d 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
2bb79c7 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
fb83952 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
2996d46 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
ab907f2 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
c05b949 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
46b6ab1 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
3fd1fa4 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
5a85c9e 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
60b4b48 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
dd34fd6 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
059a54c 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
018bded 
…tter/flutter#99419)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
f8eee10 Revert "Draggable can be accepted when the data is null" (flu…
cb1b549 
…tter/flutter#99419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renyou renyou renyou approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @renyou @fluttergithubbot