Skip to content

Fix: Date picker interactive sample not loading #99401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 8, 2022
Merged

Fix: Date picker interactive sample not loading #99401

fluttergithubbot merged 1 commit into from
Mar 8, 2022

Conversation

@maheshj01
Copy link
Member

@maheshj01 maheshj01 commented Mar 2, 2022

Fixes interactive sample not loading

Fixes: #99338

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 2, 2022
HansMuller
HansMuller approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HansMuller
HansMuller approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 2, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@HansMuller
Copy link
Contributor

HansMuller commented Mar 2, 2022

The Google Testing failure doesn't appear to have anything to with this PR:

google3:///[mobile/flutter/tools/icon_font/bin/icon_map_generator.dart:24](https://cs.corp.google.com/piper///depot/google3/mobile/flutter/tools/icon_font/bin/icon_map_generator.dart?l=24&ws=tap-presubmit-rerun-server/458933&snapshot=2):24: Error: Method not found: 'stringToTokenPairMap'.
  final tokenPairMap = stringToTokenPairMap(codepointsString);

I'll rerun the test however this PR will probably need to be sync'd with master (rebased).

@maheshj01
Copy link
Member Author

maheshj01 commented Mar 3, 2022

Unfortunately, rebase does not fix the Google testing failure

@fluttergithubbot fluttergithubbot merged commit 6e2d314 into flutter:master Mar 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
cef6540 
…ter#99401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
8ed762b 
…ter#99401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
a4bdff9 
…ter#99401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
0245b43 
…ter#99401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
4d4e723 
…ter#99401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
89e74b6 
…ter#99401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
03d0e2a 
…ter#99401)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
50abf32 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
a999560 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
5a6d708 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
10f6601 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
7f1d117 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
dd05cc2 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
69b553b 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
beb056b 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
0aaa5e2 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
eb51479 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
b30d27d 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
a4f6059 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
c22c211 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
42fc8a5 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
528412d 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
7f0b154 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
6a7765e 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
8b9cffa 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
cca87c1 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
120ee84 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
4482348 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
85d06bd 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
514a9f8 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
f4bd72e 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
2dd9203 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
54a99e9 
…ter#99401)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
6e2d314 Fix: Date picker interactive sample not loading (flutter/flut…
5ba4c0e 
…ter#99401)
This was referenced Mar 1, 2024
Closed
Merged
auto-submit bot pushed a commit that referenced this pull request Mar 1, 2024
@TahaTesser
Fix showDateRangePicker is missing dartpad tag and cleanup (#144475)
9a83845 
fixes [`showDateRangePicker` interactive sample not loading](#144474)

### Description 

This fixes `showDateRangePicker` example not loading in Dartpad.

Similar fix was made for `showDatePicker` in #99401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

showDateRangePicker sample is broken on docs

4 participants

@maheshj01 @fluttergithubbot @HansMuller @TahaTesser