Skip to content

CupertinoSliverNavigationBar: Add example #99384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gspencergoog merged 3 commits into from
Mar 3, 2022
Merged

CupertinoSliverNavigationBar: Add example #99384

gspencergoog merged 3 commits into from
Mar 3, 2022

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Mar 2, 2022

Part of #72926

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 2, 2022
@TahaTesser TahaTesser requested a review from gspencergoog March 2, 2022 12:04
gspencergoog
gspencergoog approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Just some nits. Thanks for the example!

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 3, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog gspencergoog merged commit d1daa5d into flutter:master Mar 3, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
d9d25f3 
…99384)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
373cb3c 
…99384)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
ad08469 
…99384)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
eb26ee3 
…99384)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
23eb4b3 
…99384)
@TahaTesser TahaTesser deleted the cupertini_sliver_nav_bar_example branch March 3, 2022 09:31
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
fd3b75b 
…99384)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
cb57462 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
8c681c4 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
1a63704 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
7a07e43 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
dd66e54 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
fa3f349 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
ca2ac7b 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
a3c2295 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
0d1f22c 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
6dadd74 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
9860838 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
da3840f 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
142f919 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
f6925bb 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
8493e5c 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
ebf8e85 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
d118f3a 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
3775223 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
6257f77 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
35c886e 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
d847de5 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
aeb603d 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
f0d71eb 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
49e9049 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
4eb0673 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
dd9016b 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
0dc7b5b 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
06b4345 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
dc4a883 
…99384)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d1daa5d CupertinoSliverNavigationBar: Add example (flutter/flutter#…
f5cf2eb 
…99384)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @fluttergithubbot @gspencergoog