Skip to content

Limit overscroll stretching #99364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 2, 2022
Merged

Limit overscroll stretching #99364

fluttergithubbot merged 1 commit into from
Mar 2, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 2, 2022

Fixes #99264

This limits the amount of stretch that the indicator can reach, regardless of how many pointers you apply.
(I see you #11884 😝 )

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added platform-android Android applications specifically framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: fidelity Matching the OEM platforms better f: scrolling Viewports, list views, slivers, etc. labels Mar 2, 2022
@Piinks Piinks requested a review from goderbauer March 2, 2022 00:25
goderbauer
goderbauer approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Mar 2, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor Author

Piinks commented Mar 2, 2022

There are some approved customer screenshot tests that capture the stretch changing here. Updating these is expected. Setting the google testing shard to green manually to land.

@fluttergithubbot fluttergithubbot merged commit d211f3f into flutter:master Mar 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
b185240
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
1447e53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
2a35f68
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
0ed3cb4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
5318b73
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
865076b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
d40d495
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
1149f89
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
52cd81f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
b686d6c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
a1e14fd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
cc7b7da
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
2e72210
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
e81b0a3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
b27d0aa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
5c845d7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
e7dfbca
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
390a0a4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
e8d4334
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
f50224a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
77a4cae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
66cec20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
bcca740
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
5de8040
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
db1b6e1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
1d6c125
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
4e05c64
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
19ec9f4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
5ba934c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
c6e2fc7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
6dd89b6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
b9b8425
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
91a4649
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
80cc4f1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
0ba1171
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
b01b282
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
6fe2dc7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
d211f3f Limit overscroll stretching (flutter/flutter#99364)
1e0eb78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: fidelity Matching the OEM platforms better f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. platform-android Android applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android] Lists with AndroidOverscrollIndicator.stretch can be over scrolled infinitely with multi-touch

3 participants

@Piinks @fluttergithubbot @goderbauer