Skip to content

Fix a Scrollbar hittest penetration issue #99328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Mar 2, 2022
Merged

Fix a Scrollbar hittest penetration issue #99328

fluttergithubbot merged 2 commits into from
Mar 2, 2022

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Mar 1, 2022

Fixes #99324

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Mar 1, 2022
@xu-baolin xu-baolin requested a review from Piinks March 1, 2022 09:01
Piinks
Piinks approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks for the fix!
LGTM

@Piinks Piinks added waiting for tree to go green f: gestures flutter/packages/flutter/gestures repository. labels Mar 2, 2022
@fluttergithubbot fluttergithubbot merged commit 4b20ce7 into flutter:master Mar 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
cfbe66c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
af9b18d 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
ac6d1e1 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
b46c22b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
366cfbb 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
d44b0a2 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
1df217b 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
6872837 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
26cb0e1 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
e8faa78 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
dd0e311 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
9b65794 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
7c71302 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
cd576a1 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
f8fb1d1 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
a765f04 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
d7f9b93 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
9bdb79f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
469f972 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
b8e9b13 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
da16952 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
656cb72 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
1d92b7b 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
825434e 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
f18c3fd 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
961f36a 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
b2f203a 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
6ee2c22 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
df139dd 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
cae0ad1 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
91a4552 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
c7c7989 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
45308ce 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
ef86400 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
d5d8039 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
68a2d63 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
592f143 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
6b8f0e6 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
4b20ce7 Fix a Scrollbar hittest penetration issue (flutter/flutter#99328
85a841f 
)
@Piinks Piinks mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

f: gestures flutter/packages/flutter/gestures repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scrollbar hittest penetration issue

3 participants

@xu-baolin @Piinks @fluttergithubbot