[Keyboard] Correctly convert down events that are immediately synthesized released #99200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
…down-synthesized-released
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
… synthesized released (flutter/flutter#99200)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2022
… synthesized released (flutter/flutter#99200)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR possibly fixes #99196.
The current logic that converts
RawKeyEvents toKeyEvents might crash if the current event is a down event, but the key is absent fromRawKeyboard.keysPressed.The exact reason that this happens on Android (currently the only platform that uses this logic) is unknown. The unit test uses a made-up scenario where a ShiftLeft key is pressed but the modifier bits are empty. This test indeed crashed pre-PR.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.