Skip to content

Remove redundant properties passed to _Editable #99192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 2 commits into from
Mar 1, 2022
Merged

Remove redundant properties passed to _Editable #99192

fluttergithubbot merged 2 commits into from
Mar 1, 2022

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Feb 26, 2022 •
edited
Loading

Description

This change removes some properties that were not being used by RenderEditable but are being passed to _Editable.

autocorrect
enableSuggestions
SmartQuotesType
SmartDashesType

Related Issues

Tests

Only deleting code, test-exempt.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • [-] I listed at least one issue that this PR fixes in the description above.
  • [-] I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Feb 26, 2022
@Renzo-Olivares Renzo-Olivares marked this pull request as ready for review February 26, 2022 03:35
justinmc
justinmc approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM 👍 . No tests needed.

As mentioned offline we should watch for internal test breakages since this changes a public API.

@fluttergithubbot fluttergithubbot merged commit 54b7b5c into flutter:master Mar 1, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
fe0a9aa 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
65cadc9 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
da13406 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
ab9fcd2 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
f6c51e0 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
5927702 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
863f542 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
c6f5c86 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
20ab86e 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
c12ec32 
…ter#99192)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
7de739e 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
def9b0e 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
7146627 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
a51d7dc 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
64611a2 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
a916d82 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
c3827c2 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
797440b 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
1d478d7 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
da92182 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
da7931d 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
6ab32d7 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
7c275bd 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
d0849c8 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
356dd2a 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
46dff87 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
6d7e49d 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
1cc96d7 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
e61d290 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
28c5f9d 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
2cd5146 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
e597503 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
d86579c 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
582050b 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
536220c 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
171b3ff 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
db87a7c 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
71039b8 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
dfa45c9 
…ter#99192)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
54b7b5c Remove redundant properties passed to _Editable (flutter/flut…
5ac7b43 
…ter#99192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Renzo-Olivares @justinmc @fluttergithubbot