Skip to content

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Feb 26, 2022

Fixes #98608

Rather than requiring the user to know the correct increment level for the next release version, instead have the tool auto-determine the next version with the algorithm:

  1. if the tip of the candidate branch is also on master, that means this is the first release on the branch; compute the version from the candidate branch (this would fail if the candidate branch was named wrong) and tag the branch point, then increment the n for the actual release
  2. else if the channel is stable, the increment should be z (the tool already has logic to "increment" to 0 if this is the first stable release)
  3. else (i.e. channel is beta), increment the n

Also, provide an optional --version-override command-line option, for situations where we need to tell the tool exactly which version to use.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 26, 2022
@christopherfujino christopherfujino changed the title [flutter_tools] deprecate increment [flutter_conductor] deprecate increment Feb 26, 2022
@christopherfujino christopherfujino marked this pull request as ready for review February 28, 2022 20:52
@itsjustkevin
Copy link
Contributor

@christopherfujino A few things I notice:

  1. How does this handle the case of bumping the x value (Flutter 3.0.0) Is this one of the cases where we would override?
  2. I did not see an update to the README.

@christopherfujino
Copy link
Contributor Author

@christopherfujino A few things I notice:

  1. How does this handle the case of bumping the x value (Flutter 3.0.0) Is this one of the cases where we would override?

Yes we would need to. I don't think the conductor should ever assume that the X is going to be incremented.

  1. I did not see an update to the README.

Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flutter_conductor] deprecate the --increment flag

3 participants