Add regression test for #98973 #99187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
blasten
force-pushed
the
test_surface
branch
from
9ecd097 to
a683f4a
Compare
Member
There was a problem hiding this comment.
What does the second call to setEnabledSystemUIMode(immersiveSticky) do?
Author
There was a problem hiding this comment.
it should do nothing, but this future won't resolve if the main thread is blocked. I can add a comment to clarify.
blasten
force-pushed
the
test_surface
branch
from
298bba5 to
f7b2b83
Compare
keyonghan
reviewed
Feb 26, 2022
.ci.yaml
Outdated
| tags: > | ||
| ["framework","hostonly","shard"] | ||
| - name: Mac_android android_choreographer_do_frame_test |
Contributor
There was a problem hiding this comment.
An entry is needed in TESTOWNERS to unblock the Linux test_ownership failure.
jason-simmons
approved these changes
Feb 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test exercises Choreographer#doFrame during application startup in debug, profile and release modes.
Trace: https://ui.perfetto.dev/#!/?s=da6628c3a92456ae8fa3f345d0186e781da77e90fc8a64d073e9fee11d1e65
Regression test for #98973