[flutter_conductor] log to stderr but do not crash conductor if branch name validation fails #99181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
c: contributor-productivity
godofredoc
approved these changes
Feb 25, 2022
Contributor
godofredoc
left a comment
godofredoc
left a comment
There was a problem hiding this comment.
Thanks! this will help us double check any use cases that require --force instead of blindly applying it to every command.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 25, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 26, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 26, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 26, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 26, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 26, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 26, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 26, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 27, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 27, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 27, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 28, 2022
…if branch name validation fails (flutter/flutter#99181)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
…h name validation fails (flutter#99181)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #99180
This feature was added as a sanity check to ensure we are following the release process correctly, with an override available via the
--forceflag in: #92064However, the candidate branch names have been incorrect for a while, and as a result the --force flag is always provided, which sort of defeats the purpose of this check. Thus, make this a STDERR warning but do not block execution so that the
--forceflag can be reserved for special cases.