Skip to content

[ci.yaml] Migrate roller to cocoon scheduler #99162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Mar 1, 2022
Merged

[ci.yaml] Migrate roller to cocoon scheduler #99162

fluttergithubbot merged 1 commit into from
Mar 1, 2022

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Feb 25, 2022

#92300

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

keyonghan
keyonghan reviewed Feb 25, 2022
View reviewed changes
.ci.yaml
properties:
tags: >
["framework","hostonly","shard"]
scheduler: luci
Copy link
Contributor

@keyonghan keyonghan Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bringup: true to validate first?

Copy link
Contributor Author

@CaseyHillers CaseyHillers Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since flutter/flutter's ci.yaml changes a lot, i'd rather leave it blocking. I plan to use the engine PR to validate before landing this one.

@skia-gold
Copy link

skia-gold commented Feb 25, 2022

Gold has detected about 3 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/99162

@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Mar 1, 2022
@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented Mar 1, 2022

Friendly ping. Engine ci.yaml roller is running fine on the cocoon scheduler

keyonghan
keyonghan approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fluttergithubbot fluttergithubbot merged commit 3131699 into master Mar 1, 2022
@fluttergithubbot fluttergithubbot deleted the CaseyHillers-patch-1 branch March 1, 2022 20:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
3131699 [ci.yaml] Migrate roller to cocoon scheduler (flutter/flutter…
aa34a11 
…#99162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
3131699 [ci.yaml] Migrate roller to cocoon scheduler (flutter/flutter…
83b746b 
…#99162)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 1, 2022
@engine-flutter-autoroll
3131699 [ci.yaml] Migrate roller to cocoon scheduler (flutter/flutter…
2d8c7fc 
…#99162)
@CaseyHillers CaseyHillers mentioned this pull request Mar 2, 2022
Merged
CaseyHillers added a commit that referenced this pull request Mar 2, 2022
@CaseyHillers
Revert "[ci.yaml] Migrate roller to cocoon scheduler (#99162)"
679ff05 
This reverts commit 3131699.
mdebbar pushed a commit that referenced this pull request Mar 2, 2022
Revert "[ci.yaml] Migrate roller to cocoon scheduler (#99162)" (#99375)
12bec57
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
[ci.yaml] Migrate roller to cocoon scheduler (flutter#99162)
ad6162e
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
Revert "[ci.yaml] Migrate roller to cocoon scheduler (flutter#99162)" (…
fdc76d3 
…flutter#99375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godofredoc godofredoc Awaiting requested review from godofredoc

1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CaseyHillers @skia-gold @keyonghan @goderbauer @fluttergithubbot