Skip to content

use dart pub deps to analyze consumer dependencies #99079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 25, 2022
Merged

use dart pub deps to analyze consumer dependencies #99079

fluttergithubbot merged 1 commit into from
Feb 25, 2022

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Feb 24, 2022 •
edited by christopherfujino
Loading

  • Ensures that we use the current set of dependencies, and not the newly resolved versions from a subset of packages. Due to pinning or other constraints, this could resolve to different versions of various packages.

  • Removes purely dev dependencies. Since these do not impact our users the cost is different.

Fixes #91757

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 24, 2022
christopherfujino
christopherfujino approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

jmagman
jmagman approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Excellent news!"
Thanks!

@fluttergithubbot fluttergithubbot merged commit 83a8805 into flutter:master Feb 25, 2022
@jonahwilliams jonahwilliams deleted the fix_dependency_analysis branch February 25, 2022 03:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
bfdd7aa 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
94af1c0 
…lutter#99079)
@jmagman jmagman mentioned this pull request Feb 25, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
44f8be2 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
62be71a 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
587fbc5 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
cc70cc2 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
7f69ae2 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
f796dfb 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
393b150 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
2928ecb 
…lutter#99079)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
8ed3672 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
173c8a9 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
f8f93fe 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
b03a031 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
4b005bd 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
d5f7792 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
8c73282 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
07ec909 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
137d542 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
ed5dec3 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
59fb8a5 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
0b0bd03 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
e756a03 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
26f1b1b 
…lutter#99079)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
83a8805 use dart pub deps to analyze consumer dependencies (flutter/f…
4471f07 
…lutter#99079)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@jonahwilliams @clocksmith
use dart pub deps to analyze consumer dependencies (flutter#99079)
a094ebd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

checkConsumerDependencies test should validate checked in deps

4 participants

@jonahwilliams @jmagman @christopherfujino @fluttergithubbot