Support route on ios #99078
Merged
Support route on ios #99078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
Closed
8 tasks
Jasguerrero
commented
Mar 2, 2022
TESTOWNERS
Outdated
| /dev/devicelab/bin/tasks/platform_views_scroll_perf__timeline_summary.dart @zanderso @flutter/engine | ||
| /dev/devicelab/bin/tasks/plugin_dependencies_test.dart @jmagman @flutter/tool | ||
| /dev/devicelab/bin/tasks/routing_test.dart @zanderso @flutter/tool | ||
| /dev/devicelab/bin/tasks/route_test.dart @zanderso @flutter/tool |
Contributor
Author
There was a problem hiding this comment.
Does the renaming of this test file affect metrics? @keyonghan
Contributor
There was a problem hiding this comment.
I think it's renaming the builder in the .ci.yaml that might be an issue: we're already running this as "Linux_android routing_test" today: https://ci.chromium.org/p/flutter/builders/prod/Linux_android%20routing_test.
Contributor
There was a problem hiding this comment.
For metrics, are you referring to Skia perf metrics? If yes, then this file name change will affect the metrics. Skia perf metrics are now relying on task names, instead of builder names.
Contributor
There was a problem hiding this comment.
Oh, I see. @Jasguerrero do we need to change the task name?
Contributor
Author
There was a problem hiding this comment.
@christopherfujino I don't think is necessary if it brings more problems than what it solves (just kind of confusing the task name is routing_test and the driver is route_test). I will be renaming it back to "routing_test"
CaseyHillers
approved these changes
Mar 3, 2022
keyonghan
reviewed
Mar 3, 2022
| /dev/devicelab/bin/tasks/post_backdrop_filter_perf_ios__timeline_summary.dart @zanderso @flutter/engine | ||
| /dev/devicelab/bin/tasks/simple_animation_perf_ios.dart @zanderso @flutter/engine | ||
| /dev/devicelab/bin/tasks/tiles_scroll_perf_ios__timeline_summary.dart @zanderso @flutter/engine | ||
| /dev/devicelab/bin/tasks/routing_test.dart @zanderso @flutter/tool |
Contributor
There was a problem hiding this comment.
This entry is not needed as we have already defined it in the linux section.
Could you please add a section like ## Linux android and Mac iOS Devicelab tests above the host only section, and add the shared entry there?
Contributor
|
Looks like the engine change for this should be in the framework: #99446 |
keyonghan
approved these changes
Mar 3, 2022
Contributor
keyonghan
left a comment
keyonghan
left a comment
There was a problem hiding this comment.
Thanks for the update! LGTM.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4703
This depend on an engine PR to merge first: flutter/engine#31555
Pre-launch Checklist
///).