Skip to content

Revert "Assert golden files use the right extension" #99075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
harryterkelsen merged 1 commit into from
Feb 24, 2022
Merged

Revert "Assert golden files use the right extension" #99075

harryterkelsen merged 1 commit into from
Feb 24, 2022

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Feb 24, 2022

Reverts #99016

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 24, 2022
christopherfujino
christopherfujino approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harryterkelsen
Copy link
Contributor Author

harryterkelsen commented Feb 24, 2022

The original PR caused this test to fail: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_integration_tests_2_4/3362/overview

@harryterkelsen harryterkelsen merged commit 735f9ab into master Feb 24, 2022
@harryterkelsen harryterkelsen deleted the revert-99016-pngGold branch February 24, 2022 18:44
@harryterkelsen harryterkelsen mentioned this pull request Feb 24, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
9d19fc8 
…flutter/flutter#99075)
This was referenced Feb 24, 2022
Merged
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
5c2e7c8 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
ca21394 
…flutter/flutter#99075)
@Piinks Piinks mentioned this pull request Feb 24, 2022
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
23d31bb 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
188a4dd 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
46affec 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
29df366 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 25, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
3c4de27 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
4df09f1 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
485ad09 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 27, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
ae37a64 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
440d179 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
ca901c6 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
b3a0f8d 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
1f6db37 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
c280682 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
6463c33 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
f174b58 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
bd3a8db 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
a66ff83 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
547dad4 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
e1409a8 
…flutter/flutter#99075)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 28, 2022
@engine-flutter-autoroll
735f9ab Revert "Assert golden files use the right extension (#99016)" (…
6402cfe 
…flutter/flutter#99075)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
Revert "Assert golden files use the right extension (flutter#99016)" (f…
3ae17fb 
…lutter#99075)

This reverts commit ee86e61.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Awaiting requested review from Piinks

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harryterkelsen @christopherfujino