Skip to content

Avoid calling performLayout when only the relayout boundary is different #99056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Mar 9, 2022
Merged

Avoid calling performLayout when only the relayout boundary is different #99056

fluttergithubbot merged 4 commits into from
Mar 9, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Feb 24, 2022 •
edited
Loading

In theory a render subtree shouldn't redo its layout if the incoming constraints are the same and nothing in the tree is dirty. Whether a node is a relayout boundary (or who its relayout boundary is) isn't really "inherent" and shouldn't affect the subtree's layout.

This pull request:

  • Prevents RenderObject.layout from aggressively marking everything dirty in a subtree until the next relayout boundary is reached (instead mark everything dirty until the closest known repaint boundary in RenderObject.markNeedsLayout).
  • Only updates the relayout boundaries if necessary, instead of performing a full layout, for clean nodes that has the same constraints.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 24, 2022
@LongCatIsLooong LongCatIsLooong force-pushed the avoid-performLayout-on-relayout-boundary-changes branch from bd50354 to b1ffd1e Compare February 24, 2022 08:01
@LongCatIsLooong LongCatIsLooong force-pushed the avoid-performLayout-on-relayout-boundary-changes branch 2 times, most recently from 74050d8 to 51ef6ff Compare March 5, 2022 00:44
@LongCatIsLooong LongCatIsLooong force-pushed the avoid-performLayout-on-relayout-boundary-changes branch from 51ef6ff to f506e5f Compare March 5, 2022 00:55
@LongCatIsLooong LongCatIsLooong marked this pull request as ready for review March 5, 2022 01:27
goderbauer
goderbauer approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/test/rendering/relayout_boundary_test.dart Outdated
Comment on lines 57 to 59
set layoutCount(int newValue) {
renderObject.layoutCount = newValue;
}
Copy link
Member

@goderbauer goderbauer Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this setter? Maybe remove it since it is a bit doggy.

Copy link
Member

@goderbauer goderbauer Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably also remove the getter as well and just obtain the current layoutCount value in the test with tester.renderObject<RenderLayoutCount>(find.byType(RenderLayoutCount)).layoutCount. Currently the test reads a little strange with getting the layoutCount off a widget...

Copy link
Contributor Author

@LongCatIsLooong LongCatIsLooong Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to WidgetToRenderBoxAdapter instead

@fluttergithubbot fluttergithubbot merged commit bf6fcee into flutter:master Mar 9, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
8be1058 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
22bed3f 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
6cb6d80 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
0bd9d25 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
0e7d7f2 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
a7546cd 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
90e1d87 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
34048ee 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
fead26f 
… is different (flutter/flutter#99056)
LongCatIsLooong added a commit that referenced this pull request Mar 14, 2022
@LongCatIsLooong
Revert "Avoid calling performLayout when only the relayout boundary…
563ef6f 
… is different (#99056)"

This reverts commit bf6fcee.
@LongCatIsLooong LongCatIsLooong mentioned this pull request Mar 14, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
42e3a41 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
fbc87bd 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
fc4c507 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
f247987 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
dbdb777 
… is different (flutter/flutter#99056)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
2873ba8 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
afabad4 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
d6f2a29 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
864b89d 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
da1bfd3 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
abc4a72 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
c1ab911 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
380164f 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
1d5fa39 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
06a29fb 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
b7eb9e5 
… is different (flutter/flutter#99056)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
bf6fcee Avoid calling performLayout when only the relayout boundary…
de594d0 
… is different (flutter/flutter#99056)
@gnprice gnprice mentioned this pull request May 29, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LongCatIsLooong @goderbauer @fluttergithubbot